Skip to content

Conversation

williamhyun
Copy link
Member

@williamhyun williamhyun commented Nov 21, 2020

What changes were proposed in this pull request?

This PR aims to update SBT from 1.4.2 to 1.4.4.

Why are the changes needed?

This will bring the latest bug fixes.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass the CIs.

@github-actions github-actions bot added the BUILD label Nov 21, 2020
@SparkQA

This comment has been minimized.

@SparkQA
Copy link

SparkQA commented Nov 21, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36081/

@dongjoon-hyun
Copy link
Member

Retest this please

@SparkQA

This comment has been minimized.

@SparkQA
Copy link

SparkQA commented Nov 21, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36081/

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Nov 21, 2020

It seems that there is a change in SBT 1.4.3, @williamhyun .

========================================================================
Detecting binary incompatibilities with MiMa
========================================================================
[info] Detecting binary incompatibilities with MiMa using SBT with these profiles:  -Phadoop-3.2 -Phive-2.3 -Pyarn -Phive-thriftserver -Phadoop-cloud -Phive -Pkubernetes -Pkinesis-asl -Pspark-ganglia-lgpl -Pmesos
Error: Could not find or load main class org.apache.spark.tools.GenerateMIMAIgnore
[error] running /home/jenkins/workspace/SparkPullRequestBuilder/dev/mima -Phadoop-3.2 -Phive-2.3 -Pyarn -Phive-thriftserver -Phadoop-cloud -Phive -Pkubernetes -Pkinesis-asl -Pspark-ganglia-lgpl -Pmesos ; received return code 1

@SparkQA
Copy link

SparkQA commented Nov 21, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36083/

@SparkQA
Copy link

SparkQA commented Nov 21, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36083/

@dongjoon-hyun
Copy link
Member

Let's try the next version, SBT 1.4.4. I believe it will be released soon.

@williamhyun williamhyun changed the title [SPARK-33510][BUILD] Update SBT to 1.4.3 [SPARK-33510][BUILD] Update SBT to 1.4.4 Nov 23, 2020
@SparkQA
Copy link

SparkQA commented Nov 23, 2020

Test build #131521 has finished for PR 30453 at commit 81b58fb.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 23, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36124/

@SparkQA
Copy link

SparkQA commented Nov 23, 2020

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36124/

@SparkQA
Copy link

SparkQA commented Nov 23, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36132/

@SparkQA
Copy link

SparkQA commented Nov 23, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36133/

@SparkQA
Copy link

SparkQA commented Nov 23, 2020

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36133/

@SparkQA
Copy link

SparkQA commented Nov 23, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36132/

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you, @williamhyun .
Merged to master for Apache Spark 3.1.

@SparkQA
Copy link

SparkQA commented Nov 23, 2020

Test build #131530 has finished for PR 30453 at commit bff3db4.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants