Skip to content

Conversation

tedyu
Copy link
Contributor

@tedyu tedyu commented Nov 5, 2014

@pwendell @rxin
Please take a look

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: these lines are not aligned with the other dependencies.

@vanzin
Copy link
Contributor

vanzin commented Nov 5, 2014

What effect will this have on people who want/need to compile against other versions of hbase? I know hbase has been a little fast and loose about changing the structure of their dependencies, so maybe the answer is "tough luck", and that's probably fine.

@tedyu
Copy link
Contributor Author

tedyu commented Nov 5, 2014

hbase 0.98 has been declared stable release.

Since hbase 0.94 is not modularized, compilation against 0.94 or earlier releases wouldn't be supported.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@pwendell
Copy link
Contributor

pwendell commented Nov 8, 2014

@vanzin this only affects the Spark examples project, which is isolated from our normal build. So I think for normal spark users it's a no-op one way or the other.

@pwendell
Copy link
Contributor

pwendell commented Nov 8, 2014

Jenkins, test this please.

@SparkQA
Copy link

SparkQA commented Nov 8, 2014

Test build #23083 has started for PR 3115 at commit 2b079c8.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Nov 8, 2014

Test build #23083 has finished for PR 3115 at commit 2b079c8.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23083/
Test PASSed.

asfgit pushed a commit that referenced this pull request Nov 10, 2014
pwendell rxin
Please take a look

Author: tedyu <[email protected]>

Closes #3115 from tedyu/master and squashes the following commits:

2b079c8 [tedyu] SPARK-1297 Upgrade HBase dependency to 0.98

(cherry picked from commit b32734e)
Signed-off-by: Patrick Wendell <[email protected]>
@asfgit asfgit closed this in b32734e Nov 10, 2014
@cloud-fan
Copy link
Contributor

The pom.xml in example should be a good example to demonstrate how to declare hbase dependency when writing spark application for spark users. However, the pom.xml here is little verbose. For example, hbase-client has already include hbase-common and hbase-protocol, and the exclude rule looks very complicated here, is there a better and clear way to do it?

@srowen
Copy link
Member

srowen commented Nov 17, 2014

@cloud-fan I think it depends on whether the code uses hbase-common directly as well, for example. It might. Then it's more correct to depend directly on both. Excludes are the same either way. The big exclusion rule is for hbase-server here, and I think ideally it would not be a dependency. Most people wouldn't depend on the server. IIRC there was some reason it was required by the Spark example code. Hence it is included but with a lot of exclusions. If you have a solution that would sever this dependency I think it would be a clear improvement.

@tedyu
Copy link
Contributor Author

tedyu commented Nov 17, 2014

Thanks Sean for chiming in.

bq. Most people wouldn't depend on the server
Mapreduce related classes, e.g. TableMapReduceUtil, are in hbase-server

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants