Skip to content

Conversation

@HyukjinKwon
Copy link
Member

What changes were proposed in this pull request?

This PR replaces the non-ASCII characters to ASCII characters when possible in PySpark documentation

Why are the changes needed?

To avoid unnecessarily using other non-ASCII characters which could lead to the issue such as #32047 or #22782

Does this PR introduce any user-facing change?

Virtually no.

How was this patch tested?

Found via (Mac OS):

# In Spark root directory
cd python
pcregrep --color='auto' -n "[\x80-\xFF]" `git ls-files .`

@HyukjinKwon
Copy link
Member Author

This doesn't have to be backported. So I intentionally separate it from #32047.

@SparkQA
Copy link

SparkQA commented Apr 4, 2021

Test build #136890 has finished for PR 32048 at commit 8911f1d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 4, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41467/

@SparkQA
Copy link

SparkQA commented Apr 4, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41467/

@MaxGekk
Copy link
Member

MaxGekk commented Apr 4, 2021

+1, LGTM. Merging to master.
Thank you @HyukjinKwon .

@MaxGekk MaxGekk closed this in 2ca76a5 Apr 4, 2021
@HyukjinKwon
Copy link
Member Author

Thx max!

@HyukjinKwon HyukjinKwon deleted the minor-fix branch January 4, 2022 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants