Skip to content

Conversation

@mengxr
Copy link
Contributor

@mengxr mengxr commented Nov 26, 2014

We reverted #3459 in branch-1.2 due to missing import o.a.s.SparkContext._, which is no longer needed in master (#3262). This PR adds #3459 back to branch-1.2 with correct imports.

Github is out-of-sync now. The real changes are the last two commits.

User could construct an MF model directly. I added a note about the performance.

Author: Xiangrui Meng <[email protected]>

Closes apache#3459 from mengxr/SPARK-4604 and squashes the following commits:

f64bcd3 [Xiangrui Meng] organize imports
ed08214 [Xiangrui Meng] check preconditions and unit tests
a624c12 [Xiangrui Meng] make MatrixFactorizationModel public

(cherry picked from commit b5fb141)
Signed-off-by: Xiangrui Meng <[email protected]>
@SparkQA
Copy link

SparkQA commented Nov 26, 2014

Test build #23882 has started for PR 3473 at commit fcdc2df.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Nov 26, 2014

Test build #23882 has finished for PR 3473 at commit fcdc2df.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23882/
Test PASSed.

@SparkQA
Copy link

SparkQA commented Nov 26, 2014

Test build #23891 has started for PR 3473 at commit a7638a5.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Nov 26, 2014

Test build #23891 has finished for PR 3473 at commit a7638a5.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23891/
Test PASSed.

asfgit pushed a commit that referenced this pull request Nov 26, 2014
We reverted #3459 in branch-1.2 due to missing `import o.a.s.SparkContext._`, which is no longer needed in master (#3262). This PR adds #3459 back to branch-1.2 with correct imports.

Github is out-of-sync now. The real changes are the last two commits.

Author: Xiangrui Meng <[email protected]>

Closes #3473 from mengxr/SPARK-4604-1.2 and squashes the following commits:

a7638a5 [Xiangrui Meng] add import o.a.s.SparkContext._ for v1.2
b749000 [Xiangrui Meng] [SPARK-4604][MLLIB] make MatrixFactorizationModel public
@mengxr mengxr closed this Nov 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants