-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-3431] [WIP] Parallelize Scala/Java test execution #3564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c50ec06
to
5032cfa
Compare
Test build #24061 has finished for PR 3564 at commit
|
Test build #24062 has finished for PR 3564 at commit
|
Test build #24063 has finished for PR 3564 at commit
|
Test build #24066 timed out for PR 3564 at commit |
Test build #24078 timed out for PR 3564 at commit |
Test build #24145 has finished for PR 3564 at commit
|
Test build #24146 has finished for PR 3564 at commit
|
Test build #24147 has finished for PR 3564 at commit
|
Jenkins, retest this please. |
Test build #24203 has finished for PR 3564 at commit
|
Hmm, this error from the latest test is interesting:
When I comment out the line grouping tests everything runs fine. Are the forked JVMs somehow not picking up paths or whatnot correctly? |
ab127b7
to
ac73262
Compare
Test build #24271 has finished for PR 3564 at commit
|
ac73262
to
2f24a84
Compare
Test build #24289 has finished for PR 3564 at commit
|
Jenkins, retest this please. |
Test build #24300 timed out for PR 3564 at commit |
I tried running
You also see this in Jenkins. This was the sort of output-interleaving problem that I mentioned on the JIRA. I wish that there was a way to work around this, since this can make it really hard to debug failures. |
Actually, maybe the interleaving isn't a big deal as long as we can rely on the test report XML to be properly displayed in Jenkins. |
Yeah, I'm ignoring the problem of interleaved output for now since I'm hitting two more critical problems first: 1) the tests aren't running successfully, or 2) the tests aren't running faster than before. That said, I'm slowing building a better mental model of how sbt works and how it can be configured. Unfortunately, there aren't many examples out there of how to do this stuff, so I often end up trawling through posts like this one and this one to see how others have parallelized their tests. |
Test build #24395 has finished for PR 3564 at commit
|
Test build #24398 has finished for PR 3564 at commit
|
Jenkins, retest this please. |
Test build #24400 has finished for PR 3564 at commit
|
Jenkins, retest this please. |
Test build #24401 has finished for PR 3564 at commit
|
Test build #24402 has finished for PR 3564 at commit
|
Jenkins, retest this please. |
Test build #24404 has finished for PR 3564 at commit
|
Hmm, taking a second look at how the Python tests are invoked, I wonder if we can use |
By the way, I opened a question on Stack Overflow about some kind of "show execution plan" feature in sbt. It would make understanding what sbt is doing easier as we refine the build configuration. |
9f3a91b
to
00e2b93
Compare
Test build #24852 has finished for PR 3564 at commit
|
Jenkins, retest this please. |
Test build #25115 has finished for PR 3564 at commit
|
We've been slowly making progress on the streaming test refactoring and it looks like we're down to only three failing tests on this branch:
I should be able to address the |
00e2b93
to
f697a55
Compare
Sounds good. Thanks for following up; I haven't had a chance to look over this PR in a while. (Btw, I rebased for kicks. You can disregard the coming test run.) |
Test build #25136 has finished for PR 3564 at commit
|
Jenkins, retest this please. |
Test build #25706 has finished for PR 3564 at commit
|
Jenkins, retest this please. |
Test build #25870 has finished for PR 3564 at commit
|
Not sure what to make of this @JoshRosen, but there are several more test failures in the most recent run than the 3 we thought we were down to. For example, why would this DriverSuite test fail?
|
Jenkins, retest this please. |
Test build #26005 has finished for PR 3564 at commit
|
f697a55
to
5ef856d
Compare
Test build #26430 has finished for PR 3564 at commit
|
Jenkinmensch, retest this please. |
Test build #27031 timed out for PR 3564 at commit |
5ef856d
to
8c00e88
Compare
8c00e88
to
5f7683b
Compare
Test build #27961 has finished for PR 3564 at commit
|
I'd like to close this issue for now pending further development. |
This is currently a work in progress to experiment with various options for parallelizing our Scala/Java tests using sbt.