Skip to content

[SPARK-4730][YARN] Warn against deprecated YARN settings #3590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[SPARK-4730][YARN] Warn against deprecated YARN settings #3590

wants to merge 2 commits into from

Conversation

andrewor14
Copy link
Contributor

@SparkQA
Copy link

SparkQA commented Dec 3, 2014

Test build #24113 has started for PR 3590 at commit dcd1316.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Dec 3, 2014

Test build #24113 has finished for PR 3590 at commit dcd1316.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24113/
Test PASSed.

tgravescs
tgravescs reviewed Dec 4, 2014
View reviewed changes
yarn/common/src/main/scala/org/apache/spark/scheduler/cluster/YarnClientSchedulerBackend.scala Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aren't essentially all of the env variables deprecated? I know we have warnings on some throughout the code but haven't checked for all of them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually still document the rest of them in spark-env.sh

@SparkQA
Copy link

SparkQA commented Dec 10, 2014

Test build #24287 has started for PR 3590 at commit 36e0753.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Dec 10, 2014

Test build #24287 has finished for PR 3590 at commit 36e0753.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24287/
Test PASSed.

@andrewor14
Copy link
Contributor Author

Any other comments @tgravescs?

@tgravescs
Copy link
Contributor

+1 looks good.

@JoshRosen JoshRosen mentioned this pull request Dec 23, 2014
Closed
@JoshRosen
Copy link
Contributor

LGTM, too, so I'm going to merge this into master (1.3.0) and branch-1.2 (1.2.1).

asfgit pushed a commit that referenced this pull request Dec 23, 2014
@JoshRosen
[SPARK-4730][YARN] Warn against deprecated YARN settings
6a46cc3 
See https://issues.apache.org/jira/browse/SPARK-4730.

Author: Andrew Or <[email protected]>

Closes #3590 from andrewor14/yarn-settings and squashes the following commits:

36e0753 [Andrew Or] Merge branch 'master' of github.com:apache/spark into yarn-settings
dcd1316 [Andrew Or] Warn against deprecated YARN settings

(cherry picked from commit 27c5399)
Signed-off-by: Josh Rosen <[email protected]>
@asfgit asfgit closed this in 27c5399 Dec 23, 2014
@andrewor14 andrewor14 deleted the yarn-settings branch December 24, 2014 07:29
zuxqoj
zuxqoj reviewed Feb 23, 2015
View reviewed changes
yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnClientSchedulerBackend.scala
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SPARK_MASTER_MEMORY and spark.master.memory are not applicable in yarn-client mode

should be removed, please refer SPARK-1953

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zuxqoj the "master" here doesn't actually refer to the ApplicationMaster, but the driver, so SPARK-1953 is actually unrelated. It's really the result of bad naming that we inherited from a long time ago, and this is why we're deprecating it. I agree we should just remove it for 1.4.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewor14 In SPARK-1953 properties related to driver memory were removed form yarn-client mode. SPARK_MASTER_MEMORY and spark.master.memory are related to driver memory, so they should also be removed. I have created jira for it https://issues.apache.org/jira/browse/SPARK-5951

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SPARK-1953 did not remove any driver memory setting from yarn-client mode; it just introduced new ones for the AM, so it's unrelated to the discussion here. I do agree that we should remove these configs for 1.4, but the reason has nothing to do with the ApplicationMaster. Thanks for filing that JIRA.

@srowen srowen mentioned this pull request Feb 24, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@andrewor14 @SparkQA @AmplabJenkins @tgravescs @JoshRosen @zuxqoj