Skip to content

[SPARK-39784][SQL][FOLLOW-UP] Use BinaryComparison instead of Predicate (if) for type check #37278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[SPARK-39784][SQL][FOLLOW-UP] Use BinaryComparison instead of Predicate (if) for type check #37278

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50906c7
[SPARK-39784][SQL][FOLLOW-UP] Use BinaryComparison instead of Predica…
huaxingao Jul 25, 2022
bc951df
remove un-used method
huaxingao Jul 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions sql/core/src/main/scala/org/apache/spark/sql/catalyst/util/V2ExpressionBuilder.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,8 +154,8 @@ class V2ExpressionBuilder(e: Expression, isPredicate: Boolean = false) {
val r = generateExpression(b.right)
if (l.isDefined && r.isDefined) {
b match {
case _: Predicate if isBinaryComparisonOperator(b.sqlOperator) &&
l.get.isInstanceOf[LiteralValue[_]] && r.get.isInstanceOf[FieldReference] =>
case _: BinaryComparison if l.get.isInstanceOf[LiteralValue[_]] &&
r.get.isInstanceOf[FieldReference] =>
Some(new V2Predicate(flipComparisonOperatorName(b.sqlOperator),
Array[V2Expression](r.get, l.get)))
case _: Predicate =>
Expand Down Expand Up @@ -269,13 +269,6 @@ class V2ExpressionBuilder(e: Expression, isPredicate: Boolean = false) {
case _ => None
}

private def isBinaryComparisonOperator(operatorName: String): Boolean = {
operatorName match {
case ">" | "<" | ">=" | "<=" | "=" | "<=>" => true
case _ => false
}
}

private def flipComparisonOperatorName(operatorName: String): String = {
operatorName match {
case ">" => "<"
Expand Down