[SPARK-40370][SQL] Migrate type check fails to error classes in CAST #37869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
changed the title
MaxGekk
changed the title
MaxGekk
changed the title
Member
Author
|
@srielau @anchovYu @cloud-fan @gengliangwang Could you review this PR, please. |
MaxGekk
commented
Sep 14, 2022
Comment on lines
621
to
622
| "srcType" : "\"TINYINT\"", | ||
| "srcType" : "\"TINYINT\"", |
Member
Author
There was a problem hiding this comment.
We have a bug when an error message refers to the same param more than once. I will fix this separately.
Member
Author
There was a problem hiding this comment.
The fix is trivial. Will do in this PR.
cloud-fan
approved these changes
Sep 15, 2022
Member
Author
|
The failure "SQLAppStatusListenerMemoryLeakSuite.no memory leak" is not related to the changes, I believe. |
cloud-fan
reviewed
Oct 12, 2022
| "If you have to cast <srcType> to <targetType>, you can set <config> as <configVal>." | ||
| ] | ||
| }, | ||
| "CAST_WITH_FUN_SUGGESTION" : { |
Contributor
There was a problem hiding this comment.
nit: FUN is really confusing here. I think FUNC is more commonly used as a short name of FUNCTION
Member
Author
There was a problem hiding this comment.
Tell this Rust to programmers ;-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR, I propose to use error classes in the case of type check failure in the
CASTexpression.Why are the changes needed?
Migration onto error classes unifies Spark SQL error messages, and improves search-ability of errors.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
By running the modified test suites: