[SPARK-40487][SQL] Make defaultJoin in BroadcastNestedLoopJoinExec running in parallel #37930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nning in parallel
|
Can one of the admins verify this patch? |
Member
cloud-fan
reviewed
Sep 20, 2022
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastNestedLoopJoinExec.scala
Outdated
Show resolved
Hide resolved
cloud-fan
approved these changes
Sep 20, 2022
Contributor
|
makes sense, also cc @maryannxue @somani |
xingchaozh
force-pushed
the
SPARK-40487
branch
from
71863b4 to
52d4752
Compare
wangyum
reviewed
Sep 21, 2022
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastNestedLoopJoinExec.scala
Outdated
Show resolved
Hide resolved
wangyum
reviewed
Sep 21, 2022
wangyum
reviewed
Sep 21, 2022
wangyum
approved these changes
Sep 21, 2022
cloud-fan
reviewed
Sep 21, 2022
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastNestedLoopJoinExec.scala
Outdated
Show resolved
Hide resolved
Member
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently, the defaultJoin method in BroadcastNestedLoopJoinExec collects notMatchedBroadcastRows firstly, then collects matchedStreamRows. The two steps could run in parallel instead of serial.
Why are the changes needed?
Make defaultJoin in BroadcastNestedLoopJoinExec running in parallel.
Does this PR introduce any user-facing change?
NO.
How was this patch tested?
UT.