-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-40448][CONNECT][FOLLOWUP] Use more suitable variable name and fix code style. #38061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It's ok to fix code style on, for example, scala server side. I want to hold a bit on the proto side. The proto itself will evolve quickly and itself is not at a stable position now. Whatever we change now could be no longer useful soon. Plus every time we update the proto we need to update the generate file on the python side. We are planing to change the python side with some sort of automatic way for python proto generation. Before that is achieved, the idea could be that we limit changes on the proto to only core API coverage to unblock other pieces (DataFrame API support in clients etc.) |
Thank you. I will revert the changes on the proto. |
f176cdb to
59b22cc
Compare
amaliujia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
ping @grundprinzip |
|
Merged to master. |
|
@amaliujia @grundprinzip @HyukjinKwon Thank you! |
What changes were proposed in this pull request?
We are very concerned about the progress of the Spark Connect, so we understand the current draft and read preliminary implementation. We can see that some code style are inappropriate, or even cause confusion. Therefore, this PR try to correct it.
Why are the changes needed?
Fix code style on scala server side.
Does this PR introduce any user-facing change?
'No'.
Spark Connect just started.
How was this patch tested?
N/A