Skip to content

Conversation

@itholic
Copy link
Contributor

@itholic itholic commented Oct 6, 2022

What changes were proposed in this pull request?

This PR proposes to migrate 25 execution errors onto temporary error classes with the prefix _LEGACY_ERROR_TEMP_2126 to _LEGACY_ERROR_TEMP_2150.

The error classes are prefixed with _LEGACY_ERROR_TEMP_ indicates the dev-facing error messages, and won't be exposed to end users.

Why are the changes needed?

To speed-up the error class migration.

The migration on temporary error classes allow us to analyze the errors, so we can detect the most popular error classes.

Does this PR introduce any user-facing change?

No

How was this patch tested?

$ build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite"
$ build/sbt "test:testOnly *SQLQuerySuite"
$ build/sbt -Phive-thriftserver "hive-thriftserver/testOnly org.apache.spark.sql.hive.thriftserver.ThriftServerQueryTestSuite"

@itholic itholic changed the title [WIP][SPARK-40663][SQL] Migrate execution errors onto error classes: _LEGACY_ERROR_TEMP_2126-2150 [SPARK-40663][SQL] Migrate execution errors onto error classes: _LEGACY_ERROR_TEMP_2126-2150 Oct 7, 2022
@itholic itholic marked this pull request as ready for review October 7, 2022 05:58
@MaxGekk
Copy link
Member

MaxGekk commented Oct 12, 2022

@itholic Could you resolve conflicts here, please.

@itholic
Copy link
Contributor Author

itholic commented Oct 12, 2022

Resolved! Thanks for the review

@MaxGekk
Copy link
Member

MaxGekk commented Oct 12, 2022

+1, LGTM. Merging to master.
Thank you, @itholic.

@MaxGekk MaxGekk closed this in e3c70cd Oct 12, 2022
@itholic itholic deleted the SPARK-40540-2126-2150 branch April 22, 2023 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants