Skip to content

Conversation

@zhouyifan279
Copy link
Contributor

@zhouyifan279 zhouyifan279 commented Oct 9, 2022

What changes were proposed in this pull request?

Append jline option "-Djline.terminal=jline.UnsupportedTerminal" to enable the Beeline process to run in background.

Why are the changes needed?

Currently, if we execute spark Beeline in background, the Beeline process stops immediately.
image

Does this PR introduce any user-facing change?

User will be able to execute Spark Beeline in background.

How was this patch tested?

  1. Start Spark ThriftServer
  2. Execute command ./bin/beeline -u "jdbc:hive2://localhost:10000" -e "select 1;" &
  3. Verify Beeline process output in console:

image

Note

Beeline works fine on Windows when backgrounded:
image

@zhouyifan279
Copy link
Contributor Author

cc @yaooqinn

Copy link
Member

@yaooqinn yaooqinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

Copy link
Contributor

@itholic itholic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM2

@yaooqinn yaooqinn closed this in cb0d6ed Oct 12, 2022
yaooqinn pushed a commit that referenced this pull request Oct 12, 2022
…ground

### What changes were proposed in this pull request?
Append jline option "-Djline.terminal=jline.UnsupportedTerminal" to  enable the Beeline process to run in background.

### Why are the changes needed?
Currently, if we execute spark Beeline in background, the Beeline process stops immediately.
<img width="1350" alt="image" src="https://user-images.githubusercontent.com/88070094/194742935-8235b1ba-386e-4470-b182-873ef185e19f.png">

### Does this PR introduce _any_ user-facing change?
User will be able to execute Spark Beeline in background.

### How was this patch tested?

1. Start Spark ThriftServer
2. Execute command `./bin/beeline -u "jdbc:hive2://localhost:10000" -e "select 1;" &`
3. Verify Beeline process output in console:
<img width="1407" alt="image" src="https://user-images.githubusercontent.com/88070094/194743153-ff3f1d19-ac23-443b-97a6-f024719008cd.png">

### Note

Beeline works fine on Windows when backgrounded:
![image](https://user-images.githubusercontent.com/88070094/194743797-7dc4fc21-dec6-4056-8b13-21fc96f1476e.png)

Closes #38172 from zhouyifan279/SPARK-8731.

Authored-by: zhouyifan279 <[email protected]>
Signed-off-by: Kent Yao <[email protected]>
(cherry picked from commit cb0d6ed)
Signed-off-by: Kent Yao <[email protected]>
yaooqinn pushed a commit that referenced this pull request Oct 12, 2022
…ground

### What changes were proposed in this pull request?
Append jline option "-Djline.terminal=jline.UnsupportedTerminal" to  enable the Beeline process to run in background.

### Why are the changes needed?
Currently, if we execute spark Beeline in background, the Beeline process stops immediately.
<img width="1350" alt="image" src="https://user-images.githubusercontent.com/88070094/194742935-8235b1ba-386e-4470-b182-873ef185e19f.png">

### Does this PR introduce _any_ user-facing change?
User will be able to execute Spark Beeline in background.

### How was this patch tested?

1. Start Spark ThriftServer
2. Execute command `./bin/beeline -u "jdbc:hive2://localhost:10000" -e "select 1;" &`
3. Verify Beeline process output in console:
<img width="1407" alt="image" src="https://user-images.githubusercontent.com/88070094/194743153-ff3f1d19-ac23-443b-97a6-f024719008cd.png">

### Note

Beeline works fine on Windows when backgrounded:
![image](https://user-images.githubusercontent.com/88070094/194743797-7dc4fc21-dec6-4056-8b13-21fc96f1476e.png)

Closes #38172 from zhouyifan279/SPARK-8731.

Authored-by: zhouyifan279 <[email protected]>
Signed-off-by: Kent Yao <[email protected]>
(cherry picked from commit cb0d6ed)
Signed-off-by: Kent Yao <[email protected]>
@yaooqinn
Copy link
Member

thanks, merged to master/3.3/3.2

@wangyum
Copy link
Member

wangyum commented Oct 15, 2022

@zhouyifan279 Could you provide your apache jira id? We need to set the assignee:
image

sunchao pushed a commit to sunchao/spark that referenced this pull request Jun 2, 2023
…ground

### What changes were proposed in this pull request?
Append jline option "-Djline.terminal=jline.UnsupportedTerminal" to  enable the Beeline process to run in background.

### Why are the changes needed?
Currently, if we execute spark Beeline in background, the Beeline process stops immediately.
<img width="1350" alt="image" src="https://user-images.githubusercontent.com/88070094/194742935-8235b1ba-386e-4470-b182-873ef185e19f.png">

### Does this PR introduce _any_ user-facing change?
User will be able to execute Spark Beeline in background.

### How was this patch tested?

1. Start Spark ThriftServer
2. Execute command `./bin/beeline -u "jdbc:hive2://localhost:10000" -e "select 1;" &`
3. Verify Beeline process output in console:
<img width="1407" alt="image" src="https://user-images.githubusercontent.com/88070094/194743153-ff3f1d19-ac23-443b-97a6-f024719008cd.png">

### Note

Beeline works fine on Windows when backgrounded:
![image](https://user-images.githubusercontent.com/88070094/194743797-7dc4fc21-dec6-4056-8b13-21fc96f1476e.png)

Closes apache#38172 from zhouyifan279/SPARK-8731.

Authored-by: zhouyifan279 <[email protected]>
Signed-off-by: Kent Yao <[email protected]>
(cherry picked from commit cb0d6ed)
Signed-off-by: Kent Yao <[email protected]>
@zhouyifan279 zhouyifan279 deleted the SPARK-8731 branch August 14, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants