Skip to content

Conversation

@srowen
Copy link
Member

@srowen srowen commented Oct 11, 2022

What changes were proposed in this pull request?

Handle the case where the PR body is empty, when merging a PR with the merge script.

Why are the changes needed?

The script fails otherwise.
Although we should not have empty PR descriptions, it should at least not break the script.

Does this PR introduce any user-facing change?

No

How was this patch tested?

N/A

@srowen srowen self-assigned this Oct 11, 2022
Copy link
Contributor

@LuciferYang LuciferYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

@srowen
Copy link
Member Author

srowen commented Oct 11, 2022

Merged to master

@srowen srowen closed this in 8d8fac2 Oct 11, 2022
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@srowen srowen deleted the DevMergePrBody branch October 20, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants