[SPARK-40823][CONNECT][FOLLOW-UP] Fix test_connect_column_expressions.py #38308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
HyukjinKwon
changed the title
HyukjinKwon
approved these changes
Oct 19, 2022
Member
|
Merged to master. |
Contributor
|
Thank you! |
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
### What changes were proposed in this pull request?
fix test_connect_column_expressions.py
### Why are the changes needed?
master is broken
```
ERROR [0.006s]: test_column_expressions (pyspark.sql.tests.connect.test_connect_column_expressions.SparkConnectColumnExpressionSuite)
Test a more complex combination of expressions and their translation into
----------------------------------------------------------------------
Traceback (most recent call last):
File "/__w/spark/spark/python/pyspark/sql/tests/connect/test_connect_column_expressions.py", line 80, in test_column_expressions
mod_fun.unresolved_function.arguments[0].unresolved_attribute.parts, ["id"]
AttributeError: parts
```
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
test locally
Closes apache#38308 from zhengruifeng/connect_hot_fix_expressions.
Authored-by: Ruifeng Zheng <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
fix test_connect_column_expressions.py
Why are the changes needed?
master is broken
Does this PR introduce any user-facing change?
No
How was this patch tested?
test locally