[SPARK-40869][K8S] Resource name prefix should not start with a hyphen #38331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srowen
approved these changes
Oct 21, 2022
|
Can one of the admins verify this patch? |
Member
|
@tobiasstadler Could you enable github action and do a rebase according guide? |
tobiasstadler
force-pushed
the
fix-SPARK-40869
branch
from
3e0c079 to
3c403db
Compare
Contributor
Author
|
@Yikun Done |
Member
|
Thank you for pinging me, @Yikun . |
| assert(KubernetesConf.getAppNameLabel("-" + "a" * 63) === "a" * 62) | ||
| } | ||
|
|
||
| test("SPARK-40869: KubernetesConf.getResourceNamePrefix creates invalid name prefixes") { |
Member
There was a problem hiding this comment.
The test case title is too broad. Shall we match it with the title?
- test("SPARK-40869: KubernetesConf.getResourceNamePrefix creates invalid name prefixes") {
+ test("SPARK-40869: Resource name prefix should not start with a hyphen") {
dongjoon-hyun
changed the title
dongjoon-hyun
changed the title
dongjoon-hyun
changed the title
dongjoon-hyun
approved these changes
Nov 3, 2022
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM (except a comment about test case name)
Member
|
I updated the test case name and verified manually. Let me merge this |
dongjoon-hyun
added a commit
that referenced
this pull request
Nov 3, 2022
### What changes were proposed in this pull request? Strip leading - from resource name prefix ### Why are the changes needed? leading - are not allowed for resource name prefix (especially spark.kubernetes.executor.podNamePrefix) ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Unit test Closes #38331 from tobiasstadler/fix-SPARK-40869. Lead-authored-by: Tobias Stadler <[email protected]> Co-authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 7f3b598) Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun
added a commit
that referenced
this pull request
Nov 3, 2022
### What changes were proposed in this pull request? Strip leading - from resource name prefix ### Why are the changes needed? leading - are not allowed for resource name prefix (especially spark.kubernetes.executor.podNamePrefix) ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Unit test Closes #38331 from tobiasstadler/fix-SPARK-40869. Lead-authored-by: Tobias Stadler <[email protected]> Co-authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 7f3b598) Signed-off-by: Dongjoon Hyun <[email protected]>
Member
|
Merged to master/3.3/3.2 for Apache Spark 3.4/3.3.2/3.2.3. Welcome to the Apache Spark community, @tobiasstadler . Thank you again, @tobiasstadler , @srowen , @Yikun . |
Contributor
Author
|
Thank You! |
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
### What changes were proposed in this pull request? Strip leading - from resource name prefix ### Why are the changes needed? leading - are not allowed for resource name prefix (especially spark.kubernetes.executor.podNamePrefix) ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Unit test Closes apache#38331 from tobiasstadler/fix-SPARK-40869. Lead-authored-by: Tobias Stadler <[email protected]> Co-authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
sunchao
pushed a commit
to sunchao/spark
that referenced
this pull request
Jun 2, 2023
### What changes were proposed in this pull request? Strip leading - from resource name prefix ### Why are the changes needed? leading - are not allowed for resource name prefix (especially spark.kubernetes.executor.podNamePrefix) ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Unit test Closes apache#38331 from tobiasstadler/fix-SPARK-40869. Lead-authored-by: Tobias Stadler <[email protected]> Co-authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 7f3b598) Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Strip leading - from resource name prefix
Why are the changes needed?
leading - are not allowed for resource name prefix (especially spark.kubernetes.executor.podNamePrefix)
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit test