[SPARK-40229][PS][TEST][FOLLOWUP] Add openpyxl to requirements.txt
#38425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @itholic , @HyukjinKwon , @Yikun |
Contributor
|
LGTM when the test pass. Thanks! |
Member
Author
|
Thank you, @itholic . |
Yikun
approved these changes
Oct 28, 2022
Member
Yikun
left a comment
Yikun
left a comment
There was a problem hiding this comment.
LGTM, and this requirements.txt is just for dev install, we can safe to merge and don't need CI.
Member
|
@dongjoon-hyun @itholic Thanks, merged to master. |
Member
Author
|
Thank you, @Yikun . |
Member
Author
|
Thank you, @HyukjinKwon . |
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
### What changes were proposed in this pull request? This is a follow-up of apache#37671. ### Why are the changes needed? Since apache#37671 added `openpyxl` for PySpark test environments and re-enabled `test_to_excel` test, we need to add it to `requirements.txt` as PySpark test dependency explicitly. ### Does this PR introduce _any_ user-facing change? No. This is a test dependency. ### How was this patch tested? Manually. Closes apache#38425 from dongjoon-hyun/SPARK-40229. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Yikun Jiang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a follow-up of #37671.
Why are the changes needed?
Since #37671 added
openpyxlfor PySpark test environments and re-enabledtest_to_exceltest, we need to add it torequirements.txtas PySpark test dependency explicitly.Does this PR introduce any user-facing change?
No. This is a test dependency.
How was this patch tested?
Manually.