[SPARK-40769][CORE][SQL] Migrate type check failures of aggregate expressions onto error classes #38498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuciferYang
changed the title
LuciferYang
changed the title
Contributor
Author
|
Still in wip, will fix test later |
LuciferYang
changed the title
MaxGekk
requested changes
Nov 4, 2022
| "expectedNum" -> " >= 1", | ||
| "actualNum" -> "0", | ||
| "legacyNum" -> "0", | ||
| "legacyConfKey" -> SQLConf.ALLOW_PARAMETERLESS_COUNT.key, |
Member
There was a problem hiding this comment.
Please, use toSQLConf() to quote the config.
| "actualNum" -> "0", | ||
| "legacyNum" -> "0", | ||
| "legacyConfKey" -> SQLConf.ALLOW_PARAMETERLESS_COUNT.key, | ||
| "legacyConfValue" -> true.toString |
Member
There was a problem hiding this comment.
true should be quoted by "", see error-classes.json. For instance,
I would add new helper toSQLConfVal() like:
def toSQLConfVal(conf: String): String = {
quoteByDefault(conf)
}
Contributor
Author
|
GA passed |
Member
|
+1, LGTM. Merging to master. |
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
…ressions onto error classes ### What changes were proposed in this pull request? This pr aims to replace `TypeCheckFailure` by `DataTypeMismatch` in type checks in the aggregate expressions: - Count - CollectSet - CountMinSketchAgg - HistogramNumeric ### Why are the changes needed? Migration onto error classes unifies Spark SQL error messages. ### Does this PR introduce _any_ user-facing change? Yes. The PR changes user-facing error messages. ### How was this patch tested? Pass GitHub Actions Closes apache#38498 from LuciferYang/SPARK-40769. Authored-by: yangjie01 <[email protected]> Signed-off-by: Max Gekk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr aims to replace
TypeCheckFailurebyDataTypeMismatchin type checks in the aggregate expressions:Why are the changes needed?
Migration onto error classes unifies Spark SQL error messages.
Does this PR introduce any user-facing change?
Yes. The PR changes user-facing error messages.
How was this patch tested?
Pass GitHub Actions