-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-40976][BUILD] Upgrade sbt to 1.7.3 #38502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cc @dongjoon-hyun @HyukjinKwon @srowen re-upgrade sbt to 1.7.3 due to SPARK-40996 has solved the issue of also cc @linhongliu-db for double check |
|
I revised the PR title because it's okay for us to reuse the JIRA ID and title. |
|
Thanks @dongjoon-hyun |
srowen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok pending tests
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM, too.
itholic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Merged to master. |
|
@linhongliu-db Please ping me if you encounter any problems |
### What changes were proposed in this pull request? This pr aims to re-upgrade sbt to 1.7.3 due to SPARK-40996 has solved the issue of `dev/sbt-checkstyle` execution failure. ### Why are the changes needed? The release note as follows, this version just updates sbt underlying Coursier from 2.1.0-M2 to 2.1.0-M7-18-g67daad6a9: - https://github.com/sbt/sbt/releases/tag/v1.7.3 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? - Pass GitHub Actions - Manual test: Run `dev/sbt-checkstyle` with this pr ``` Checkstyle checks passed. ``` Closes apache#38502 from LuciferYang/SPARK-40976-2. Authored-by: yangjie01 <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
What changes were proposed in this pull request?
This pr aims to re-upgrade sbt to 1.7.3 due to SPARK-40996 has solved the issue of
dev/sbt-checkstyleexecution failure.Why are the changes needed?
The release note as follows, this version just updates sbt underlying Coursier from 2.1.0-M2 to 2.1.0-M7-18-g67daad6a9:
Does this PR introduce any user-facing change?
No
How was this patch tested?
dev/sbt-checkstylewith this pr