Skip to content

Conversation

@LuciferYang
Copy link
Contributor

@LuciferYang LuciferYang commented Nov 3, 2022

What changes were proposed in this pull request?

This pr aims to re-upgrade sbt to 1.7.3 due to SPARK-40996 has solved the issue of dev/sbt-checkstyle execution failure.

Why are the changes needed?

The release note as follows, this version just updates sbt underlying Coursier from 2.1.0-M2 to 2.1.0-M7-18-g67daad6a9:

Does this PR introduce any user-facing change?

No

How was this patch tested?

  • Pass GitHub Actions
  • Manual test: Run dev/sbt-checkstyle with this pr
Checkstyle checks passed.

@LuciferYang
Copy link
Contributor Author

LuciferYang commented Nov 3, 2022

cc @dongjoon-hyun @HyukjinKwon @srowen re-upgrade sbt to 1.7.3 due to SPARK-40996 has solved the issue of dev/sbt-checkstyle execution failure.

also cc @linhongliu-db for double check

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-40976][BUILD] Re-upgrade sbt to 1.7.3 [SPARK-40976][BUILD] Upgrade sbt to 1.7.3 Nov 3, 2022
@dongjoon-hyun
Copy link
Member

I revised the PR title because it's okay for us to reuse the JIRA ID and title.

@LuciferYang
Copy link
Contributor Author

Thanks @dongjoon-hyun

@github-actions github-actions bot added the BUILD label Nov 3, 2022
Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok pending tests

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM, too.

Copy link
Contributor

@itholic itholic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HyukjinKwon
Copy link
Member

Merged to master.

@LuciferYang
Copy link
Contributor Author

@linhongliu-db Please ping me if you encounter any problems

SandishKumarHN pushed a commit to SandishKumarHN/spark that referenced this pull request Dec 12, 2022
### What changes were proposed in this pull request?
This pr aims to re-upgrade sbt to 1.7.3 due to SPARK-40996 has solved the issue of `dev/sbt-checkstyle` execution failure.

### Why are the changes needed?
The release note as follows, this version just updates sbt underlying Coursier from 2.1.0-M2 to 2.1.0-M7-18-g67daad6a9:

- https://github.com/sbt/sbt/releases/tag/v1.7.3

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?

- Pass GitHub Actions
- Manual test: Run `dev/sbt-checkstyle` with this pr

```
Checkstyle checks passed.
```

Closes apache#38502 from LuciferYang/SPARK-40976-2.

Authored-by: yangjie01 <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants