[SPARK-41708][SQL][FOLLOWUP] Do not insert columnar to row transition before write command #39922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
commented
Feb 7, 2023
| assert(result(2).getLong(0) == 301L) | ||
|
|
||
| withTempPath { path => | ||
| val e = intercept[Exception](df.write.parquet(path.getCanonicalPath)) |
There was a problem hiding this comment.
without the fix, it fails with class org.apache.spark.sql.execution.WholeStageCodegenExec has write support mismatch
There was a problem hiding this comment.
Can we catch more specific exception though?
There was a problem hiding this comment.
There was a problem hiding this comment.
Got it. Since it's a test suite and this test case matches the exception message exactly, looks fine.
|
lgtm |
|
thanks for the review, merging to master/3.4! |
cloud-fan
added a commit
that referenced
this pull request
Feb 7, 2023
… before write command ### What changes were proposed in this pull request? This is a followup of #39277 . With planned write, the write command requires neither columnar nor row-based execution. It invokes a new API `executeWrite`, which returns commit messages, not columnar or row-based data. This PR updates `ApplyColumnarRulesAndInsertTransitions` to take this case into consideration. ### Why are the changes needed? If people replaces `WriteFilesExec` with a columnar version, the plan can't be executed due to an extra columnar to row transition between `WriteFilesExee` and the write command. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? new test Closes #39922 from cloud-fan/write. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> (cherry picked from commit 56dd20f) Signed-off-by: Wenchen Fan <[email protected]>
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
… before write command ### What changes were proposed in this pull request? This is a followup of apache#39277 . With planned write, the write command requires neither columnar nor row-based execution. It invokes a new API `executeWrite`, which returns commit messages, not columnar or row-based data. This PR updates `ApplyColumnarRulesAndInsertTransitions` to take this case into consideration. ### Why are the changes needed? If people replaces `WriteFilesExec` with a columnar version, the plan can't be executed due to an extra columnar to row transition between `WriteFilesExee` and the write command. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? new test Closes apache#39922 from cloud-fan/write. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> (cherry picked from commit 56dd20f) Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a followup of #39277 . With planned write, the write command requires neither columnar nor row-based execution. It invokes a new API
executeWrite, which returns commit messages, not columnar or row-based data.This PR updates
ApplyColumnarRulesAndInsertTransitionsto take this case into consideration.Why are the changes needed?
If people replaces
WriteFilesExecwith a columnar version, the plan can't be executed due to an extra columnar to row transition betweenWriteFilesExeeand the write command.Does this PR introduce any user-facing change?
No
How was this patch tested?
new test