Skip to content

[SPARK-5282][mllib]: RowMatrix easily gets int overflow in the memory size warning #4069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[SPARK-5282][mllib]: RowMatrix easily gets int overflow in the memory size warning #4069

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7afac23
5282: fix int overflow in the warning
hhbyyh Jan 17, 2015
e54e5c8
change to MB based number
hhbyyh Jan 18, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/RowMatrix.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,8 @@ class RowMatrix(
throw new IllegalArgumentException(s"Argument with more than 65535 cols: $cols")
}
if (cols > 10000) {
val mem = cols * cols * 8
logWarning(s"$cols columns will require at least $mem bytes of memory!")
val memMB = (cols.toLong * cols) / 125000
logWarning(s"$cols columns will require at least $memMB megabytes of memory!")
}
}

Expand Down