Skip to content

Conversation

@zsxwing
Copy link
Member

@zsxwing zsxwing commented Jan 23, 2015

No description provided.

@zsxwing zsxwing changed the title [SPARK-5214][Test] Add a test to demonstrate EventLoop can be stopped in the event loop thread [SPARK-5214][Test] Add a test to demonstrate EventLoop can be stopped in the event thread Jan 23, 2015
@SparkQA
Copy link

SparkQA commented Jan 23, 2015

Test build #26009 has started for PR 4174 at commit 7aaa2d7.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Jan 23, 2015

Test build #26009 has finished for PR 4174 at commit 7aaa2d7.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class Rating(userId: Int, movieId: Int, rating: Float, timestamp: Long)
    • case class Movie(movieId: Int, title: String, genres: Seq[String])
    • case class Params(
    • class ALS extends Estimator[ALSModel] with ALSParams
    • case class RatingBlock(srcIds: Array[Int], dstIds: Array[Int], ratings: Array[Float])

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26009/
Test PASSed.

@srowen
Copy link
Member

srowen commented Jan 23, 2015

This was meant to go with #4016 ?

@zsxwing
Copy link
Member Author

zsxwing commented Jan 23, 2015

This was meant to go with #4016 ?

I didn't consider this case when doing #4016. Although #4016 happens to work, I still think it's worth to add a test to prevent later changes from breaking it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we reduce the check interval to like 5ms? Ideally unit tests should run in a very short amount of time. Having to wait 200ms is pretty long. Would be great to change rest of this file also.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@SparkQA
Copy link

SparkQA commented Jan 24, 2015

Test build #26049 has started for PR 4174 at commit 443e564.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Jan 24, 2015

Test build #26049 has finished for PR 4174 at commit 443e564.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26049/
Test PASSed.

@rxin
Copy link
Contributor

rxin commented Jan 24, 2015

Thanks. Merging in master.

@asfgit asfgit closed this in 0d1e67e Jan 24, 2015
@zsxwing zsxwing deleted the SPARK-5214-unittest branch January 26, 2015 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants