Skip to content

SPARK-1934 [CORE] "this" reference escape to "selectorThread" during construction in ConnectionManager #4225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

SPARK-1934 [CORE] "this" reference escape to "selectorThread" during construction in ConnectionManager #4225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions core/src/main/scala/org/apache/spark/network/nio/ConnectionManager.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,14 +184,16 @@ private[nio] class ConnectionManager(
// to be able to track asynchronous messages
private val idCount: AtomicInteger = new AtomicInteger(1)

private val writeRunnableStarted: HashSet[SelectionKey] = new HashSet[SelectionKey]()
private val readRunnableStarted: HashSet[SelectionKey] = new HashSet[SelectionKey]()

private val selectorThread = new Thread("connection-manager-thread") {
override def run() = ConnectionManager.this.run()
}
selectorThread.setDaemon(true)
// start this thread last, since it invokes run(), which accesses members above
selectorThread.start()

private val writeRunnableStarted: HashSet[SelectionKey] = new HashSet[SelectionKey]()

private def triggerWrite(key: SelectionKey) {
val conn = connectionsByKey.getOrElse(key, null)
if (conn == null) return
Expand Down Expand Up @@ -232,7 +234,6 @@ private[nio] class ConnectionManager(
} )
}

private val readRunnableStarted: HashSet[SelectionKey] = new HashSet[SelectionKey]()

private def triggerRead(key: SelectionKey) {
val conn = connectionsByKey.getOrElse(key, null)
Expand Down