[SPARK-44995][K8S] Promote SparkKubernetesClientFactory to DeveloperApi
#42709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
changed the title
SparkKubernetesClientFactory to DeveloperApi
dongjoon-hyun
force-pushed
the
SPARK-44995
branch
from
f9da7e0 to
d1e13b4
Compare
HyukjinKwon
approved these changes
Aug 28, 2023
viirya
approved these changes
Aug 28, 2023
|
Thank you, @HyukjinKwon and @viirya ! |
|
Merged to master for Apache Spark 4. |
viirya
pushed a commit
to viirya/spark-1
that referenced
this pull request
Oct 19, 2023
…erApi` ### What changes were proposed in this pull request? This PR aims to promote `SparkKubernetesClientFactory` as **stable** `DeveloperApi` in order to maintain it officially in a backward compatible way at Apache Spark 4.0.0. ### Why are the changes needed? Like SPARK-35280 and SPARK-37497, `SparkKubernetesClientFactory` is also able to be used to develop new `ExternalClusterManager` for K8s environment. - apache#32406 - apache#34751 ### Does this PR introduce _any_ user-facing change? No. Previously, it was `private[spark]`. ### How was this patch tested? Manual review because this is only a visibility change. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#42709 from dongjoon-hyun/SPARK-44995. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit c596fce) Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to promote
SparkKubernetesClientFactoryas stableDeveloperApiin order to maintain it officially in a backward compatible way at Apache Spark 4.0.0.Why are the changes needed?
Like SPARK-35280 and SPARK-37497,
SparkKubernetesClientFactoryis also able to be used to develop newExternalClusterManagerfor K8s environment.ExecutorPods[PollingSnapshot|WatchSnapshot]Sourceto DeveloperApi #34751Does this PR introduce any user-facing change?
No. Previously, it was
private[spark].How was this patch tested?
Manual review because this is only a visibility change.
Was this patch authored or co-authored using generative AI tooling?
No.