Skip to content

[SPARK-5759][Yarn]ExecutorRunnable should catch YarnException while NMClient start contain... #4554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[SPARK-5759][Yarn]ExecutorRunnable should catch YarnException while NMClient start contain... #4554

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c02140f
ExecutorRunnable should catch YarnException while NMClient start cont…
lianhuiwang Feb 12, 2015
caf5a99
use SparkException to warp exception
lianhuiwang Feb 12, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions yarn/src/main/scala/org/apache/spark/deploy/yarn/ExecutorRunnable.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ import org.apache.hadoop.yarn.conf.YarnConfiguration
import org.apache.hadoop.yarn.ipc.YarnRPC
import org.apache.hadoop.yarn.util.{ConverterUtils, Records}

import org.apache.spark.{SecurityManager, SparkConf, Logging}
import org.apache.spark.{SparkException, SecurityManager, SparkConf, Logging}
Copy link
Contributor

@sryza sryza Feb 12, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: imports should be ordered alphabetically, so SparkException should come after SparkConf here

import org.apache.spark.network.util.JavaUtils

class ExecutorRunnable(
Expand Down Expand Up @@ -109,7 +109,13 @@ class ExecutorRunnable(
}

// Send the start request to the ContainerManager
nmClient.startContainer(container, ctx)
try {
nmClient.startContainer(container, ctx)
} catch {
case ex: Exception =>
throw new SparkException("Exception while starting container ${container.getId}" +
Copy link
Contributor

@sryza sryza Feb 12, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need an "s" before the quote for the interpolation to work.

" on host $hostname", ex)
}
}

private def prepareCommand(
Expand Down