[SPARK-47448][CORE] Enable spark.shuffle.service.removeShuffle by default
#45572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
changed the title
spark.shuffle.service.removeShuffle by default
Member
Author
|
WDYT, @Kimahriman, @mridulm , @tgravescs , @Ngone51 ? |
Contributor
|
seems fine to me but I haven't tested with this feature much. +1 |
Member
Author
|
Thank you for the valuable feedback, @tgravescs . |
Contributor
|
I've been using it heavily in production since I added it so definitely good with me. |
Member
Author
|
Thank you, @Kimahriman ! |
Contributor
|
Same as Tom, we are on an older version, so I have not used it in production - but toggling it to default should be fine. |
Member
Author
|
Thank you, @mridulm . |
Member
Author
|
Merged to master for Apache Spark 4.0.0. Thank you all! |
sweisdb
pushed a commit
to sweisdb/spark
that referenced
this pull request
Apr 1, 2024
…efault ### What changes were proposed in this pull request? This PR aims to enable `spark.shuffle.service.removeShuffle` for Apache Spark 4.0.0. ### Why are the changes needed? Since Apache Spark 3.3.0, Apache Spark has been supporting `spark.shuffle.service.removeShuffle` via SPARK-37618. - apache#35085 We can use it when external shuffle service is available. ### Does this PR introduce _any_ user-facing change? By default, no because `spark.shuffle.service.enabled` is still disabled. Only for the existing shuffle service users, this PR works. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#45572 from dongjoon-hyun/SPARK-47448. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to enable
spark.shuffle.service.removeShufflefor Apache Spark 4.0.0.Why are the changes needed?
Since Apache Spark 3.3.0, Apache Spark has been supporting
spark.shuffle.service.removeShufflevia SPARK-37618.We can use it when external shuffle service is available.
Does this PR introduce any user-facing change?
By default, no because
spark.shuffle.service.enabledis still disabled.Only for the existing shuffle service users, this PR works.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.