[SPARK-47781][SQL] Handle negative scale decimals for JDBC data sources #45956
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
SPARK-30252 has disabled the definition of the negative scale for decimals. It has a regression that also disabled reading negative scale decimals from JDBC data sources. Although there is a legacy config to restore the old behavior, it seemed neither designed for such a case nor convenient in a data pipeline that extracts negative scale decimals from a database such as Oracle to Parquet files w/o negative scale decimal support.
In addition, Postgres has the negative scale decimals support since v15, which was one of the supporters for disabling negative scale decimals on our side.
In this PR, we change the schema from
decimal(p,s)todecimal(p-s,0)if s<0.Why are the changes needed?
Does this PR introduce any user-facing change?
Negative scale decimals have many supporters for rounding the internal parts, such as Oracle, Postgres, etc.
How was this patch tested?
new tests
Was this patch authored or co-authored using generative AI tooling?
no