check whether RocksDB already loads with the latest snapshot #46927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When using RocksDB state store provider to load a given checkpoint, if the RocksDB's loaded version != the checkpoint version, RocksDB will first load the latest snapshot that is prior to the checkpoint version. Right now without checking whether the RockDB is already loaded with the latest snapshot, RocksDB will always be closed and restarted. This PR proposes to first check the version before restart the DB.
Why are the changes needed?
In some case (though may be rare), RocksDB instance is already loaded with the latest snapshot version, so it does not have to be restarted. This PR can eliminate this unnecessary overhead.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Passing all existing test suites.
Was this patch authored or co-authored using generative AI tooling?
No.