[SPARK-48764][PYTHON] Filtering out IPython-related frames from user stack #47159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
approved these changes
Jul 1, 2024
|
Merged to master. |
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Oct 4, 2024
…stack ### What changes were proposed in this pull request? This PR proposes to fix internal function `_capture_call_site` for filtering out IPython-related frames from user stack. ### Why are the changes needed? IPython-related frames are unnecessarily polluting the user stacks so it harms debuggability of IPython Notebook. For example, there are some garbage stacks recorded from `IPython` and `ipykernel` such as: - `...lib/python3.9/site-packages/IPython/core/interactiveshell.py...` - `...lib/python3.9/site-packages/ipykernel/zmqshell.py...` ### Does this PR introduce _any_ user-facing change? No API changes, but the user stack from IPython will be cleaned up as below: **Before** <img width="457" alt="Screenshot 2024-07-01 at 3 26 45 PM" src="https://github.com/apache/spark/assets/44108233/67ba8b49-f52f-4a7d-8031-b7272fceb581"> **After** <img width="456" alt="Screenshot 2024-07-01 at 3 25 07 PM" src="https://github.com/apache/spark/assets/44108233/950035cd-4397-41a5-9664-7040b84ebd6f"> ### How was this patch tested? The existing CI should pass ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#47159 from itholic/ipython_followup. Authored-by: Haejoon Lee <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to fix internal function
_capture_call_sitefor filtering out IPython-related frames from user stack.Why are the changes needed?
IPython-related frames are unnecessarily polluting the user stacks so it harms debuggability of IPython Notebook.
For example, there are some garbage stacks recorded from
IPythonandipykernelsuch as:...lib/python3.9/site-packages/IPython/core/interactiveshell.py......lib/python3.9/site-packages/ipykernel/zmqshell.py...Does this PR introduce any user-facing change?
No API changes, but the user stack from IPython will be cleaned up as below:
Before
After
How was this patch tested?
The existing CI should pass
Was this patch authored or co-authored using generative AI tooling?
No