[SPARK-19335][SPARK-38200][SQL] Add upserts for writing to JDBC #49528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
reviewed
Jan 17, 2025
sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala
Outdated
Show resolved
Hide resolved
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
Outdated
Show resolved
Hide resolved
connector/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/UpsertTests.scala
Outdated
Show resolved
Hide resolved
beliefer
reviewed
Mar 6, 2025
| truncateTable(conn, options) | ||
| val tableSchema = JdbcUtils.getSchemaOption(conn, options) | ||
| saveTable(df, tableSchema, isCaseSensitive, options) | ||
| saveTable(df, tableSchema, isCaseSensitive, upsert, options) |
There was a problem hiding this comment.
It looks strange that apply upsert if SaveMode is Overwrite here.
beliefer
reviewed
Mar 6, 2025
| dropTable(conn, options.table, options) | ||
| createTable(conn, options.table, df.schema, isCaseSensitive, options) | ||
| saveTable(df, Some(df.schema), isCaseSensitive, options) | ||
| saveTable(df, Some(df.schema), isCaseSensitive, upsert, options) |
beliefer
reviewed
Mar 6, 2025
- Use SparkUnsupportedOperationException - Remove unused string interpolation - Fix indentation
|
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a follow-up on #16685 and #16692.
Implements upsert mode for
SaveMode.Appendof the MySql, MsSql, and Postgres JDBC source.See #41611 for an alternative using the
MERGE INTOcommand (not supported by MySql).Why are the changes needed?
The JDBC writer only supports either truncating the existing table or inserting. Duplicates, i.e. rows with identical values in the primary or unique index columns, cause an exception, permitting updating existing and inserting new rows.
Re-evaluating a partition due to executor loss will insert rows that have been inserted in an earlier attempt, which kills the entier Spark job.
Does this PR introduce any user-facing change?
This adds
upsertandupsertKeyColumnsoptions forSaveMode.Appendof the JDBC source.How was this patch tested?
Tests in
JdbcSuiteand integration suites.