[SPARK-54140][INFRA] Add libwebp-dev to fix dev/spark-test-image/lint/Dockerfile building
#52838
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…int/Dockerfile` building
|
Could you review this INFRA PR when you have some time, @peter-toth and @attilapiros ? |
peter-toth
approved these changes
Nov 2, 2025
|
Yeah, I know this problem. Thanks @dongjoon-hyun for the fix. |
|
Thank you so much, @peter-toth ! |
|
I verified this locally too. As a release manager, I'm going to merge this to recover |
dongjoon-hyun
added a commit
that referenced
this pull request
Nov 2, 2025
…int/Dockerfile` building ### What changes were proposed in this pull request? This PR aims to add `libwebp-dev` to fix `dev/spark-test-image/lint/Dockerfile` building in both `master` and `branch-4.1`. ### Why are the changes needed? Currently, `dev/spark-test-image/lint/Dockerfile` fails to build. - For master branch, it wasn't revealed yet because we use the cached image. - For `branch-4.1`, it is currently breaking the CIs. - https://github.com/apache/spark/tree/branch-4.1 - https://github.com/apache/spark/actions/runs/19015025991/job/54307102990 ``` #9 454.6 -------------------------- [ERROR MESSAGE] --------------------------- #9 454.6 <stdin>:1:10: fatal error: ft2build.h: No such file or directory #9 454.6 compilation terminated. #9 454.6 -------------------------------------------------------------------- #9 454.6 ERROR: configuration failed for package 'ragg' #9 454.6 * removing '/usr/local/lib/R/site-library/ragg' ``` ### Does this PR introduce _any_ user-facing change? No behavior change. ### How was this patch tested? Pass the CIs. Especially, `Base image build` job. - https://github.com/dongjoon-hyun/spark/actions/runs/19018354185/job/54309542386 ### Was this patch authored or co-authored using generative AI tooling? No. Closes #52838 from dongjoon-hyun/SPARK-54140. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 25aa49a) Signed-off-by: Dongjoon Hyun <[email protected]>
|
Merged to master/4.1 for Apache Spark 4.1.0. |
|
For the record, Unlike |
dongjoon-hyun
added a commit
that referenced
this pull request
Nov 3, 2025
…/Dockerfile` ### What changes were proposed in this pull request? This PR aims to add `libwebp-dev` to all `dev/spark-test-image/*/Dockerfile`. ### Why are the changes needed? Like we hit this issue before, this happens at all related docker images. - #52290 - #52838 I checked `dev` directory. - https://github.com/apache/spark/tree/branch-4.1/dev To put it simply consistent with `spark-rm/Dockerfile` behavior, we need this additionally 13 places because `libwebp-dev` is used only 3 times while `libtiff5-dev` is used 16 times. ``` $ git grep libtiff5-dev dev | wc -l 16 $ git grep libwebp-dev dev | wc -l 3 ``` ### Does this PR introduce _any_ user-facing change? No behavior change. ### How was this patch tested? Manual review. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #52846 from dongjoon-hyun/SPARK-54148. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun
added a commit
that referenced
this pull request
Nov 3, 2025
…/Dockerfile` ### What changes were proposed in this pull request? This PR aims to add `libwebp-dev` to all `dev/spark-test-image/*/Dockerfile`. ### Why are the changes needed? Like we hit this issue before, this happens at all related docker images. - #52290 - #52838 I checked `dev` directory. - https://github.com/apache/spark/tree/branch-4.1/dev To put it simply consistent with `spark-rm/Dockerfile` behavior, we need this additionally 13 places because `libwebp-dev` is used only 3 times while `libtiff5-dev` is used 16 times. ``` $ git grep libtiff5-dev dev | wc -l 16 $ git grep libwebp-dev dev | wc -l 3 ``` ### Does this PR introduce _any_ user-facing change? No behavior change. ### How was this patch tested? Manual review. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #52846 from dongjoon-hyun/SPARK-54148. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit f5bd5d0) Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to add
libwebp-devto fixdev/spark-test-image/lint/Dockerfilebuilding in bothmasterandbranch-4.1.Why are the changes needed?
Currently,
dev/spark-test-image/lint/Dockerfilefails to build.branch-4.1, it is currently breaking the CIs.Does this PR introduce any user-facing change?
No behavior change.
How was this patch tested?
Pass the CIs. Especially,
Base image buildjob.Was this patch authored or co-authored using generative AI tooling?
No.