Skip to content

Conversation

@tsudukim
Copy link
Contributor

@tsudukim tsudukim commented Apr 3, 2015

escape spaces in the arguments.

…at has space in its path

escape spaces in the arguments.
@SparkQA
Copy link

SparkQA commented Apr 3, 2015

Test build #29664 has started for PR 5347 at commit 9180aaf.

@tsudukim
Copy link
Contributor Author

tsudukim commented Apr 3, 2015

This PR requires #5227 merged. (https://issues.apache.org/jira/browse/SPARK-6435)

@SparkQA
Copy link

SparkQA commented Apr 3, 2015

Test build #29664 has finished for PR 5347 at commit 9180aaf.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29664/
Test FAILed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, is this specific to Windows, even? if I had a path with a space on Linux it would fail similarly, I'd imagine? I bet we dont' get that case right either.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, forgot to consider Linux since I have hardly ever seen the path with spaces in Linux.
I'll move this code to somewhere else.

@asfgit asfgit closed this in 596ba77 Apr 7, 2015
@mengxr
Copy link
Contributor

mengxr commented Apr 7, 2015

Sorry that I accidentally merged this PR instead of another one. I reverted the commit. So please reopen this PR and continue the discussion.

@tsudukim
Copy link
Contributor Author

tsudukim commented Apr 8, 2015

OK, but is it available to reopen the merged pull request? I can't find the reopen button.
If we can't reopen it, I'll send another PR.

@tsudukim
Copy link
Contributor Author

New version #5447 is sent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants