Skip to content

Conversation

@shivaram
Copy link
Contributor

This prevents tools like devtools::document creating invalid collate orders

This prevents tools like devtools::document creating invalid
collate orders
@shivaram
Copy link
Contributor Author

cc @cafreeman @davies

@cafreeman
Copy link

You may want to pull in the schema changes from earlier today since SQLtypes.R was replaced with schema.R

@SparkQA
Copy link

SparkQA commented Apr 11, 2015

Test build #30058 has finished for PR 5462 at commit f3db562.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

@shivaram
Copy link
Contributor Author

@cafreeman We will pull that change in #5436 and @davies will take care of merging it correctly.

@davies
Copy link
Contributor

davies commented Apr 16, 2015

LGTM.

@shivaram Could you merge this today? then I can rebase #5436

@SparkQA
Copy link

SparkQA commented Apr 16, 2015

Test build #684 has finished for PR 5462 at commit f3db562.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

@shivaram
Copy link
Contributor Author

Thanks @davies - I don't think the error has anything to do with this PR, but let me retest it anyways to be safe

Jenkins, retest this please

@SparkQA
Copy link

SparkQA commented Apr 16, 2015

Test build #686 has finished for PR 5462 at commit f3db562.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

@asfgit asfgit closed this in 55f553a Apr 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants