Skip to content

[SPARK-6765] Fix test code style for core. #5484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[SPARK-6765] Fix test code style for core. #5484

wants to merge 1 commit into from

Conversation

@rxin
Copy link
Contributor

@rxin rxin commented Apr 12, 2015

No description provided.

@SparkQA
Copy link

SparkQA commented Apr 13, 2015

Test build #30126 has finished for PR 5484 at commit e0b0100.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

aarondav
aarondav reviewed Apr 13, 2015
View reviewed changes
core/src/test/scala/org/apache/spark/deploy/rest/StandaloneRestSubmitSuite.scala
Copy link
Contributor

@aarondav aarondav Apr 13, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one is generally OK, right? Not that it's less wrong this way, but just unnecessary.

Copy link
Contributor Author

@rxin rxin Apr 13, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will trigger the linter.

@rxin
Copy link
Contributor Author

rxin commented Apr 13, 2015

Merging in master.

@asfgit asfgit closed this in a1fe59d Apr 13, 2015
@rxin rxin mentioned this pull request Apr 13, 2015
Closed
asfgit pushed a commit that referenced this pull request Apr 13, 2015
@rxin
[SPARK-6765] Enable scalastyle on test code.
c5b0b29 
Turn scalastyle on for all test code. Most of the violations have been resolved in my previous pull requests:

Core: #5484
SQL: #5412
MLlib: #5411
GraphX: #5410
Streaming: #5409

Author: Reynold Xin <[email protected]>

Closes #5486 from rxin/test-style-enable and squashes the following commits:

01683de [Reynold Xin] Fixed new code.
a4ab46e [Reynold Xin] Fixed tests.
20adbc8 [Reynold Xin] Missed one violation.
5e36521 [Reynold Xin] [SPARK-6765] Enable scalastyle on test code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rxin @SparkQA @aarondav