Skip to content

[SPARK-6852][SPARKR] Accept numeric as numPartitions in SparkR. #5613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[SPARK-6852][SPARKR] Accept numeric as numPartitions in SparkR. #5613

wants to merge 2 commits into from

Conversation

@sun-rui
Copy link
Contributor

@sun-rui sun-rui commented Apr 21, 2015

No description provided.

@shivaram
Copy link
Contributor

shivaram commented Apr 22, 2015

Jenkins, ok to test

@shivaram
Copy link
Contributor

shivaram commented Apr 22, 2015

Jenkins, add to whitelist

@shivaram
Copy link
Contributor

shivaram commented Apr 22, 2015

Thanks @sun-rui -- Change looks good to me. Lets wait for Jenkins

@SparkQA
Copy link

SparkQA commented Apr 23, 2015

Test build #30792 has finished for PR 5613 at commit 29d67c1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

@shivaram
Copy link
Contributor

shivaram commented Apr 23, 2015

One change that isn't in RDD.R or pairRDD.R is that sortBy and sortByKey take in 1L as the default argument in generics.R. Could you change that to just 1 (numeric) and check if sortByKey(rdd, 2) etc. works correctly ?

@SparkQA
Copy link

SparkQA commented Apr 24, 2015

Test build #30907 has finished for PR 5613 at commit abaf02e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

@shivaram
Copy link
Contributor

shivaram commented Apr 24, 2015

LGTM. Merging this

@asfgit asfgit closed this in caf0136 Apr 24, 2015
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request May 14, 2015
[SPARK-6852] [SPARKR] Accept numeric as numPartitions in SparkR.
66871b4 
Author: Sun Rui <[email protected]>

Closes apache#5613 from sun-rui/SPARK-6852 and squashes the following commits:

abaf02e [Sun Rui] Change the type of default numPartitions from integer to numeric in generics.R.
29d67c1 [Sun Rui] [SPARK-6852][SPARKR] Accept numeric as numPartitions in SparkR.
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
@nemccarthy
[SPARK-6852] [SPARKR] Accept numeric as numPartitions in SparkR.
5ef9048 
Author: Sun Rui <[email protected]>

Closes apache#5613 from sun-rui/SPARK-6852 and squashes the following commits:

abaf02e [Sun Rui] Change the type of default numPartitions from integer to numeric in generics.R.
29d67c1 [Sun Rui] [SPARK-6852][SPARKR] Accept numeric as numPartitions in SparkR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sun-rui @shivaram @SparkQA