Skip to content

Conversation

brkyvz
Copy link
Contributor

@brkyvz brkyvz commented May 5, 2015

After a discussion on the user mailing list, it was decided to put all UDF's under o.a.s.sql.functions

cc @rxin

@SparkQA
Copy link

SparkQA commented May 5, 2015

Test build #31908 has finished for PR 5923 at commit cf7a7bb.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@brkyvz
Copy link
Contributor Author

brkyvz commented May 5, 2015

retest this please

@SparkQA
Copy link

SparkQA commented May 5, 2015

Test build #31911 has finished for PR 5923 at commit cf7a7bb.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@brkyvz
Copy link
Contributor Author

brkyvz commented May 5, 2015

retest this please

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

float(col1) ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should I just remove these lines and do it in the function call?

@SparkQA
Copy link

SparkQA commented May 6, 2015

Test build #31913 has finished for PR 5923 at commit cf7a7bb.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor

rxin commented May 6, 2015

LGTM

@SparkQA
Copy link

SparkQA commented May 6, 2015

Test build #31940 has finished for PR 5923 at commit a8dc3f7.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor

rxin commented May 6, 2015

Merging in master & branch-1.4. Thanks.

@asfgit asfgit closed this in ba2b566 May 6, 2015
asfgit pushed a commit that referenced this pull request May 6, 2015
After a discussion on the user mailing list, it was decided to put all UDF's under `o.a.s.sql.functions`

cc rxin

Author: Burak Yavuz <[email protected]>

Closes #5923 from brkyvz/move-math-funcs and squashes the following commits:

a8dc3f7 [Burak Yavuz] address comments
cf7a7bb [Burak Yavuz] [SPARK-7358] Move DataFrame mathfunctions into functions

(cherry picked from commit ba2b566)
Signed-off-by: Reynold Xin <[email protected]>
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request May 28, 2015
After a discussion on the user mailing list, it was decided to put all UDF's under `o.a.s.sql.functions`

cc rxin

Author: Burak Yavuz <[email protected]>

Closes apache#5923 from brkyvz/move-math-funcs and squashes the following commits:

a8dc3f7 [Burak Yavuz] address comments
cf7a7bb [Burak Yavuz] [SPARK-7358] Move DataFrame mathfunctions into functions
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request Jun 12, 2015
After a discussion on the user mailing list, it was decided to put all UDF's under `o.a.s.sql.functions`

cc rxin

Author: Burak Yavuz <[email protected]>

Closes apache#5923 from brkyvz/move-math-funcs and squashes the following commits:

a8dc3f7 [Burak Yavuz] address comments
cf7a7bb [Burak Yavuz] [SPARK-7358] Move DataFrame mathfunctions into functions
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
After a discussion on the user mailing list, it was decided to put all UDF's under `o.a.s.sql.functions`

cc rxin

Author: Burak Yavuz <[email protected]>

Closes apache#5923 from brkyvz/move-math-funcs and squashes the following commits:

a8dc3f7 [Burak Yavuz] address comments
cf7a7bb [Burak Yavuz] [SPARK-7358] Move DataFrame mathfunctions into functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants