[SPARK-1442][SQL][follow-up] Address minor comments in Window Function PR (#5604). #5945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged build triggered. |
|
Merged build started. |
|
Merged build finished. Test FAILed. |
|
Test FAILed. |
|
Test build #769 has started for PR 5945 at commit |
|
Can you put "window function" on the title also? |
yhuai
changed the title
yhuai
changed the title
|
Test build #769 has finished for PR 5945 at commit
|
|
@yhuai Could you also check the build error I see in #5604 (comment) ? |
|
Merged build triggered. |
|
Merged build started. |
|
Test build #32122 has started for PR 5945 at commit |
|
Test build #32122 has finished for PR 5945 at commit
|
|
Merged build finished. Test PASSed. |
|
Test PASSed. |
|
Thanks, merged to master and 1.4. |
asfgit
pushed a commit
that referenced
this pull request
May 7, 2015
…ion PR (#5604). Address marmbrus and scwf's comments in #5604. Author: Yin Huai <[email protected]> Closes #5945 from yhuai/windowFollowup and squashes the following commits: 0ef879d [Yin Huai] Add collectFirst to TreeNode. 2373968 [Yin Huai] wip 4a16df9 [Yin Huai] Address minor comments for [SPARK-1442]. (cherry picked from commit 5784c8d) Signed-off-by: Michael Armbrust <[email protected]>
jeanlyn
pushed a commit
to jeanlyn/spark
that referenced
this pull request
May 28, 2015
…ion PR (apache#5604). Address marmbrus and scwf's comments in apache#5604. Author: Yin Huai <[email protected]> Closes apache#5945 from yhuai/windowFollowup and squashes the following commits: 0ef879d [Yin Huai] Add collectFirst to TreeNode. 2373968 [Yin Huai] wip 4a16df9 [Yin Huai] Address minor comments for [SPARK-1442].
jeanlyn
pushed a commit
to jeanlyn/spark
that referenced
this pull request
Jun 12, 2015
…ion PR (apache#5604). Address marmbrus and scwf's comments in apache#5604. Author: Yin Huai <[email protected]> Closes apache#5945 from yhuai/windowFollowup and squashes the following commits: 0ef879d [Yin Huai] Add collectFirst to TreeNode. 2373968 [Yin Huai] wip 4a16df9 [Yin Huai] Address minor comments for [SPARK-1442].
nemccarthy
pushed a commit
to nemccarthy/spark
that referenced
this pull request
Jun 19, 2015
…ion PR (apache#5604). Address marmbrus and scwf's comments in apache#5604. Author: Yin Huai <[email protected]> Closes apache#5945 from yhuai/windowFollowup and squashes the following commits: 0ef879d [Yin Huai] Add collectFirst to TreeNode. 2373968 [Yin Huai] wip 4a16df9 [Yin Huai] Address minor comments for [SPARK-1442].
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address @marmbrus and @scwf's comments in #5604.