Skip to content

[SPARK-7404][ml] Add RegressionEvaluator to spark.ml #6344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 9 commits into from
Closed

[SPARK-7404][ml] Add RegressionEvaluator to spark.ml #6344

wants to merge 9 commits into from

Conversation

@harsha2010
Copy link

@harsha2010 harsha2010 commented May 22, 2015

No description provided.

@harsha2010
Copy link
Author

harsha2010 commented May 22, 2015

@jkbradley
Adds Regression Evaluator as wrapper around RegressionMetrics and a test to ensure metrics match expected output.

@SparkQA
Copy link

SparkQA commented May 22, 2015

Test build #33320 has finished for PR 6344 at commit 1b6ebb3.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class RegressionEvaluator(override val uid: String)

@SparkQA
Copy link

SparkQA commented May 22, 2015

Test build #33322 has finished for PR 6344 at commit f93b812.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class RegressionEvaluator(override val uid: String)

mengxr
mengxr reviewed May 22, 2015
View reviewed changes
mllib/src/main/scala/org/apache/spark/ml/evaluation/RegressionEvaluator.scala Outdated
Copy link
Contributor

@mengxr mengxr May 22, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge master and use spark.ml.evaluation.Evaluator. Sorry for the API change!

@SparkQA
Copy link

SparkQA commented May 22, 2015

Test build #33326 has finished for PR 6344 at commit f5b6a4c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class RegressionEvaluator(override val uid: String)

@SparkQA
Copy link

SparkQA commented May 22, 2015

Test build #33324 timed out for PR 6344 at commit 32dd310 after a configured wait of 150m.

@SparkQA
Copy link

SparkQA commented May 22, 2015

Test build #33332 has finished for PR 6344 at commit c46044d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented May 22, 2015

Test build #33333 has finished for PR 6344 at commit 16b9d77.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

asfgit pushed a commit that referenced this pull request May 22, 2015
@mengxr
[SPARK-7404] [ML] Add RegressionEvaluator to spark.ml
d709d7c 
Author: Ram Sriharsha <[email protected]>

Closes #6344 from harsha2010/SPARK-7404 and squashes the following commits:

16b9d77 [Ram Sriharsha] consistent naming
7f100b6 [Ram Sriharsha] cleanup
c46044d [Ram Sriharsha] Merge with Master + Code Review Fixes
188fa0a [Ram Sriharsha] Merge branch 'master' into SPARK-7404
f5b6a4c [Ram Sriharsha] cleanup doc
97beca5 [Ram Sriharsha] update test to use R packages
32dd310 [Ram Sriharsha] fix indentation
f93b812 [Ram Sriharsha] fix test
1b6ebb3 [Ram Sriharsha] [SPARK-7404][ml] Add RegressionEvaluator to spark.ml

(cherry picked from commit f490b3b)
Signed-off-by: Xiangrui Meng <[email protected]>
@asfgit asfgit closed this in f490b3b May 22, 2015
@mengxr
Copy link
Contributor

mengxr commented May 22, 2015

LGTM. Merged into master and branch-1.4. Thanks! Are you interested in adding the Python wrapper as well? It should be straightforward:

https://github.com/apache/spark/blob/master/python/pyspark/ml/evaluation.py#L87

jkbradley
jkbradley reviewed May 22, 2015
View reviewed changes
mllib/src/main/scala/org/apache/spark/ml/evaluation/RegressionEvaluator.scala
Copy link
Member

@jkbradley jkbradley May 22, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

final class

@jkbradley
Copy link
Member

jkbradley commented May 22, 2015

@harsha2010 I wrote the comments on the train and submitted them before realizing the PR had been closed already. Can you please include them in a follow-up PR (e.g., if you add a Python API)? Thanks!

@harsha2010
Copy link
Author

harsha2010 commented May 22, 2015

@mengxr , sure will write up the python part.
@jkbradley , thanks for the review, will incorporate the feedback in the python wrapper PR

jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request May 28, 2015
@jeanlyn
[SPARK-7404] [ML] Add RegressionEvaluator to spark.ml
4a158bc 
Author: Ram Sriharsha <[email protected]>

Closes apache#6344 from harsha2010/SPARK-7404 and squashes the following commits:

16b9d77 [Ram Sriharsha] consistent naming
7f100b6 [Ram Sriharsha] cleanup
c46044d [Ram Sriharsha] Merge with Master + Code Review Fixes
188fa0a [Ram Sriharsha] Merge branch 'master' into SPARK-7404
f5b6a4c [Ram Sriharsha] cleanup doc
97beca5 [Ram Sriharsha] update test to use R packages
32dd310 [Ram Sriharsha] fix indentation
f93b812 [Ram Sriharsha] fix test
1b6ebb3 [Ram Sriharsha] [SPARK-7404][ml] Add RegressionEvaluator to spark.ml
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request Jun 12, 2015
@jeanlyn
[SPARK-7404] [ML] Add RegressionEvaluator to spark.ml
7dcc1cd 
Author: Ram Sriharsha <[email protected]>

Closes apache#6344 from harsha2010/SPARK-7404 and squashes the following commits:

16b9d77 [Ram Sriharsha] consistent naming
7f100b6 [Ram Sriharsha] cleanup
c46044d [Ram Sriharsha] Merge with Master + Code Review Fixes
188fa0a [Ram Sriharsha] Merge branch 'master' into SPARK-7404
f5b6a4c [Ram Sriharsha] cleanup doc
97beca5 [Ram Sriharsha] update test to use R packages
32dd310 [Ram Sriharsha] fix indentation
f93b812 [Ram Sriharsha] fix test
1b6ebb3 [Ram Sriharsha] [SPARK-7404][ml] Add RegressionEvaluator to spark.ml
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
@nemccarthy
[SPARK-7404] [ML] Add RegressionEvaluator to spark.ml
356b1d7 
Author: Ram Sriharsha <[email protected]>

Closes apache#6344 from harsha2010/SPARK-7404 and squashes the following commits:

16b9d77 [Ram Sriharsha] consistent naming
7f100b6 [Ram Sriharsha] cleanup
c46044d [Ram Sriharsha] Merge with Master + Code Review Fixes
188fa0a [Ram Sriharsha] Merge branch 'master' into SPARK-7404
f5b6a4c [Ram Sriharsha] cleanup doc
97beca5 [Ram Sriharsha] update test to use R packages
32dd310 [Ram Sriharsha] fix indentation
f93b812 [Ram Sriharsha] fix test
1b6ebb3 [Ram Sriharsha] [SPARK-7404][ml] Add RegressionEvaluator to spark.ml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@harsha2010 @SparkQA @mengxr @jkbradley