Skip to content

Conversation

@mengxr
Copy link
Contributor

@mengxr mengxr commented Jun 2, 2015

The new test uses CV to compare maxIter=0 and maxIter=1, and validate on the evaluation result. @jkbradley

@jkbradley
Copy link
Member

Just to check, if you run with maxIter=0, does this give a different evaluation metric result?
If so, then LGTM

@SparkQA
Copy link

SparkQA commented Jun 2, 2015

Test build #33958 has finished for PR 6572 at commit c236bb8.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@mengxr
Copy link
Contributor Author

mengxr commented Jun 2, 2015

With maxIter=0, areaUnderROC is 0.5.

@asfgit asfgit closed this in bd97840 Jun 2, 2015
asfgit pushed a commit that referenced this pull request Jun 2, 2015
The new test uses CV to compare `maxIter=0` and `maxIter=1`, and validate on the evaluation result. jkbradley

Author: Xiangrui Meng <[email protected]>

Closes #6572 from mengxr/SPARK-7432 and squashes the following commits:

c236bb8 [Xiangrui Meng] fix flacky cv doctest

(cherry picked from commit bd97840)
Signed-off-by: Xiangrui Meng <[email protected]>
@mengxr
Copy link
Contributor Author

mengxr commented Jun 2, 2015

Merged into master and branch-1.4.

jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request Jun 12, 2015
The new test uses CV to compare `maxIter=0` and `maxIter=1`, and validate on the evaluation result. jkbradley

Author: Xiangrui Meng <[email protected]>

Closes apache#6572 from mengxr/SPARK-7432 and squashes the following commits:

c236bb8 [Xiangrui Meng] fix flacky cv doctest
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
The new test uses CV to compare `maxIter=0` and `maxIter=1`, and validate on the evaluation result. jkbradley

Author: Xiangrui Meng <[email protected]>

Closes apache#6572 from mengxr/SPARK-7432 and squashes the following commits:

c236bb8 [Xiangrui Meng] fix flacky cv doctest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants