Skip to content

Conversation

@davies
Copy link
Contributor

@davies davies commented Jun 2, 2015

add schema()/format()/options() for reader, add mode()/format()/options()/partitionBy() for writer

cc @rxin @yhuai @pwendell

@rxin
Copy link
Contributor

rxin commented Jun 2, 2015

lol I've been working on this too in the last 20 mins.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since 1.4?

@rxin
Copy link
Contributor

rxin commented Jun 2, 2015

LGTM. We should add tests too (maybe later so we can make this in 1.4)

@SparkQA
Copy link

SparkQA commented Jun 2, 2015

Test build #33965 has finished for PR 6578 at commit 1299ab6.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jun 2, 2015

Test build #33969 has finished for PR 6578 at commit b65dfa2.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jun 2, 2015

Test build #33970 has finished for PR 6578 at commit 720d293.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@pwendell
Copy link
Contributor

pwendell commented Jun 2, 2015

Jenkins, retest this please.

@pwendell
Copy link
Contributor

pwendell commented Jun 2, 2015

This failed a totally unrelated streaming test, so I think it's okay.

@asfgit asfgit closed this in 445647a Jun 2, 2015
asfgit pushed a commit that referenced this pull request Jun 2, 2015
…th Scala

add schema()/format()/options() for reader,  add mode()/format()/options()/partitionBy() for writer

cc rxin yhuai  pwendell

Author: Davies Liu <[email protected]>

Closes #6578 from davies/readwrite and squashes the following commits:

720d293 [Davies Liu] address comments
b65dfa2 [Davies Liu] Update readwriter.py
1299ab6 [Davies Liu] make Python API consistent with Scala

(cherry picked from commit 445647a)
Signed-off-by: Patrick Wendell <[email protected]>
@rxin
Copy link
Contributor

rxin commented Jun 2, 2015

@pwendell but Python hasn't even run yet because it runs after the Scala streaming tests

@SparkQA
Copy link

SparkQA commented Jun 2, 2015

Test build #33993 has finished for PR 6578 at commit 720d293.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jun 2, 2015

Test build #870 has finished for PR 6578 at commit 720d293.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request Jun 12, 2015
…th Scala

add schema()/format()/options() for reader,  add mode()/format()/options()/partitionBy() for writer

cc rxin yhuai  pwendell

Author: Davies Liu <[email protected]>

Closes apache#6578 from davies/readwrite and squashes the following commits:

720d293 [Davies Liu] address comments
b65dfa2 [Davies Liu] Update readwriter.py
1299ab6 [Davies Liu] make Python API consistent with Scala
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
…th Scala

add schema()/format()/options() for reader,  add mode()/format()/options()/partitionBy() for writer

cc rxin yhuai  pwendell

Author: Davies Liu <[email protected]>

Closes apache#6578 from davies/readwrite and squashes the following commits:

720d293 [Davies Liu] address comments
b65dfa2 [Davies Liu] Update readwriter.py
1299ab6 [Davies Liu] make Python API consistent with Scala
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants