[SPARK-6723] [MLLIB] Model import/export for ChiSqSelector #6785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
nit: Using sqlContext.createDataFrame can save you from importing sqlContext.implicits._
|
Can you fix merge conflicts so I can try it out? |
added 2 commits
October 3, 2015 02:26
Conflicts: mllib/src/main/scala/org/apache/spark/mllib/feature/ChiSqSelector.scala
|
Thanks Feyman! Cleaned up the newlines and fixed the merge conflicts. |
There was a problem hiding this comment.
nit: the two sql imports could be grouped
|
LGTM overall, some nits, ping @mengxr to trigger tests |
|
ok to test |
|
Test build #44016 has finished for PR 6785 at commit
|
|
Merged into master. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR for Parquet-based model import/export.