-
Couldn't load subscription status.
- Fork 28.9k
[SPARK-9326] Close lock file used for file downloads. #7650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
A lock file is used to ensure multiple executors running on the same machine don't download the same file concurrently. Spark never closes these lock files (releasing the lock does not close the underlying file); this commit fixes that.
|
LGTM (I assume closing the channel also closes the RAF from which is was created). |
|
(Yes, just double-checked that's the behavior for closing the channel.) |
|
Test build #38398 has finished for PR 7650 at commit
|
|
Jenkins, retest this please |
|
Test build #95 has finished for PR 7650 at commit
|
|
Jenkins, retest this please |
|
Test build #38407 has finished for PR 7650 at commit
|
|
Test build #96 has finished for PR 7650 at commit
|
|
Test build #38409 timed out for PR 7650 at commit |
|
Jenkins, retest this please |
|
Test build #38419 has finished for PR 7650 at commit
|
|
Test build #98 has finished for PR 7650 at commit
|
|
LGTM as well, so I'm going to merge this to master and branch-1.4. Thanks! |
A lock file is used to ensure multiple executors running on the same machine don't download the same file concurrently. Spark never closes these lock files (releasing the lock does not close the underlying file); this commit fixes that. cc vanzin (looks like you've been involved in various other fixes surrounding these lock files) Author: Kay Ousterhout <[email protected]> Closes #7650 from kayousterhout/SPARK-9326 and squashes the following commits: 0401bd1 [Kay Ousterhout] Close lock file used for file downloads. (cherry picked from commit 6b2baec) Signed-off-by: Josh Rosen <[email protected]>
|
Thanks @JoshRosen! |
A lock file is used to ensure multiple executors running on the
same machine don't download the same file concurrently. Spark never
closes these lock files (releasing the lock does not close the
underlying file); this commit fixes that.
cc @vanzin (looks like you've been involved in various other fixes surrounding these lock files)