Skip to content

Conversation

@kayousterhout
Copy link
Contributor

A lock file is used to ensure multiple executors running on the
same machine don't download the same file concurrently. Spark never
closes these lock files (releasing the lock does not close the
underlying file); this commit fixes that.

cc @vanzin (looks like you've been involved in various other fixes surrounding these lock files)

A lock file is used to ensure multiple executors running on the
same machine don't download the same file concurrently. Spark never
closes these lock files (releasing the lock does not close the
underlying file); this commit fixes that.
@vanzin
Copy link
Contributor

vanzin commented Jul 24, 2015

LGTM (I assume closing the channel also closes the RAF from which is was created).

@vanzin
Copy link
Contributor

vanzin commented Jul 24, 2015

(Yes, just double-checked that's the behavior for closing the channel.)

@SparkQA
Copy link

SparkQA commented Jul 24, 2015

Test build #38398 has finished for PR 7650 at commit 0401bd1.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@kayousterhout
Copy link
Contributor Author

Jenkins, retest this please

@SparkQA
Copy link

SparkQA commented Jul 24, 2015

Test build #95 has finished for PR 7650 at commit 0401bd1.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@kayousterhout
Copy link
Contributor Author

Jenkins, retest this please

@SparkQA
Copy link

SparkQA commented Jul 25, 2015

Test build #38407 has finished for PR 7650 at commit 0401bd1.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • abstract class InternalRow extends Serializable
    • class GenericRow(protected[sql] val values: Array[Any]) extends Row
    • class GenericInternalRow(protected[sql] val values: Array[Any]) extends InternalRow
    • class GenericInternalRowWithSchema(values: Array[Any], val schema: StructType)
    • class GenericMutableRow(val values: Array[Any]) extends MutableRow

@SparkQA
Copy link

SparkQA commented Jul 25, 2015

Test build #96 has finished for PR 7650 at commit 0401bd1.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 25, 2015

Test build #38409 timed out for PR 7650 at commit 0401bd1 after a configured wait of 175m.

@kayousterhout
Copy link
Contributor Author

Jenkins, retest this please

@SparkQA
Copy link

SparkQA commented Jul 25, 2015

Test build #38419 has finished for PR 7650 at commit 0401bd1.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 25, 2015

Test build #98 has finished for PR 7650 at commit 0401bd1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@JoshRosen
Copy link
Contributor

LGTM as well, so I'm going to merge this to master and branch-1.4. Thanks!

asfgit pushed a commit that referenced this pull request Jul 26, 2015
A lock file is used to ensure multiple executors running on the
same machine don't download the same file concurrently. Spark never
closes these lock files (releasing the lock does not close the
underlying file); this commit fixes that.

cc vanzin (looks like you've been involved in various other fixes surrounding these lock files)

Author: Kay Ousterhout <[email protected]>

Closes #7650 from kayousterhout/SPARK-9326 and squashes the following commits:

0401bd1 [Kay Ousterhout] Close lock file used for file downloads.

(cherry picked from commit 6b2baec)
Signed-off-by: Josh Rosen <[email protected]>
@asfgit asfgit closed this in 6b2baec Jul 26, 2015
@kayousterhout
Copy link
Contributor Author

Thanks @JoshRosen!

@kayousterhout kayousterhout deleted the SPARK-9326 branch April 11, 2017 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants