[SPARK-1901] worker should make sure executor has exited before updating executor's info #854
Conversation
…ing executor's info
|
Can one of the admins verify this patch? |
|
Jenkins, test this please. |
|
Merged build triggered. |
|
Merged build started. |
|
Merged build finished. |
|
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15143/ |
There was a problem hiding this comment.
can you add some inline javadoc to explain what message is used for?
There was a problem hiding this comment.
sure, i have appended a new commit.
|
The test failure is unrelated. @aarondav you can merge this one if you want. |
|
Hi @aarondav , do you have any thoughts on this issue? |
There was a problem hiding this comment.
Might as well add a message here like "Worker shutting down".
|
Just a couple of minor comments, otherwise LGTM. |
|
I have modified the error messages as you suggested, thank you @aarondav . |
|
Jenkins, test this please. LGTM pending tests. |
|
Merged build triggered. |
|
Merged build started. |
|
Merged build finished. All automated tests passed. |
|
All automated tests passed. |
…ing executor's info https://issues.apache.org/jira/browse/SPARK-1901 Author: Zhen Peng <[email protected]> Closes #854 from zhpengg/bugfix-worker-kills-executor and squashes the following commits: 21d380b [Zhen Peng] add some error messages 506cea6 [Zhen Peng] add some docs for killProcess() a0b9860 [Zhen Peng] [SPARK-1901] worker should make sure executor has exited before updating executor's info
|
Merged into master and branch-1.0. Thanks! |
…ing executor's info https://issues.apache.org/jira/browse/SPARK-1901 Author: Zhen Peng <[email protected]> Closes #854 from zhpengg/bugfix-worker-kills-executor and squashes the following commits: 21d380b [Zhen Peng] add some error messages 506cea6 [Zhen Peng] add some docs for killProcess() a0b9860 [Zhen Peng] [SPARK-1901] worker should make sure executor has exited before updating executor's info
|
@zhpengg mind closing this? For some reason it didn't close correctly. |
…ing executor's info https://issues.apache.org/jira/browse/SPARK-1901 Author: Zhen Peng <[email protected]> Closes apache#854 from zhpengg/bugfix-worker-kills-executor and squashes the following commits: 21d380b [Zhen Peng] add some error messages 506cea6 [Zhen Peng] add some docs for killProcess() a0b9860 [Zhen Peng] [SPARK-1901] worker should make sure executor has exited before updating executor's info
…ing executor's info https://issues.apache.org/jira/browse/SPARK-1901 Author: Zhen Peng <[email protected]> Closes apache#854 from zhpengg/bugfix-worker-kills-executor and squashes the following commits: 21d380b [Zhen Peng] add some error messages 506cea6 [Zhen Peng] add some docs for killProcess() a0b9860 [Zhen Peng] [SPARK-1901] worker should make sure executor has exited before updating executor's info
5 participants
https://issues.apache.org/jira/browse/SPARK-1901