bugfix worker DriverStateChanged state should match DriverState.FAILED #864
Conversation
|
Can one of the admins verify this patch? |
|
Jenkins, test this please. |
|
Merged build triggered. |
|
Merged build started. |
|
Merged build finished. All automated tests passed. |
|
All automated tests passed. |
There was a problem hiding this comment.
can we add a catch-all for other unknown States? It seems like there's a lot of them that we may later error on. Just something like
case _ =>
logDebug(s"Driver $driverId changed state to $state")
There was a problem hiding this comment.
Also the $state in this case will always be FAILED, so perhaps it'd be better to just say something like s"Driver $driverId exited with failure."
|
can anyone verify this patch?thanks |
|
Jenkins, add to whitelist and retest this. |
|
Merged build triggered. |
|
Merged build started. |
|
Merged build finished. All automated tests passed. |
|
All automated tests passed. |
|
LGTM, thanks! Merged into master and branch-1.0. |
bugfix worker DriverStateChanged state should match DriverState.FAILED Author: lianhuiwang <[email protected]> Closes #864 from lianhuiwang/master and squashes the following commits: 480ce94 [lianhuiwang] address aarondav comments f2b5970 [lianhuiwang] bugfix worker DriverStateChanged state should match DriverState.FAILED
bugfix worker DriverStateChanged state should match DriverState.FAILED Author: lianhuiwang <[email protected]> Closes apache#864 from lianhuiwang/master and squashes the following commits: 480ce94 [lianhuiwang] address aarondav comments f2b5970 [lianhuiwang] bugfix worker DriverStateChanged state should match DriverState.FAILED
bugfix worker DriverStateChanged state should match DriverState.FAILED Author: lianhuiwang <[email protected]> Closes apache#864 from lianhuiwang/master and squashes the following commits: 480ce94 [lianhuiwang] address aarondav comments f2b5970 [lianhuiwang] bugfix worker DriverStateChanged state should match DriverState.FAILED
3 participants
bugfix worker DriverStateChanged state should match DriverState.FAILED