Skip to content

Conversation

@wb14123
Copy link
Contributor

@wb14123 wb14123 commented Sep 24, 2015

No description provided.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from shutdown hook --> from JVM shutdown hook
streamingContext -> StreamingContext
streamingContext shutdown gracefully --> streamingContext stop gracefully from shutdown hook.

@tdas
Copy link
Contributor

tdas commented Sep 24, 2015

ok to test

@SparkQA
Copy link

SparkQA commented Sep 24, 2015

Test build #42957 has finished for PR 8898 at commit cdc7448.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Sep 24, 2015

Test build #42961 has finished for PR 8898 at commit a2e7f75.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text reads funny here. Maybe just: "If true, Spark shuts down the StreamingContext gracefully on JVM shutdown rather than immediately."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sounds better. I'm not a native English speaker so I'll modify it as your suggestion.

@SparkQA
Copy link

SparkQA commented Sep 24, 2015

Test build #42968 has finished for PR 8898 at commit 98c9f57.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Sep 27, 2015

LGTM

@asfgit asfgit closed this in fb4c7be Sep 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants