[SPARK-10845] [SQL] Makes spark.sql.hive.version a SQLConfEntry #8925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Thanks for the review. Merging to master. |
|
Test build #43052 has finished for PR 8925 at commit
|
asfgit
pushed a commit
that referenced
this pull request
Oct 14, 2015
When refactoring SQL options from plain strings to the strongly typed `SQLConfEntry`, `spark.sql.hive.version` wasn't migrated, and doesn't show up in the result of `SET -v`, as `SET -v` only shows public `SQLConfEntry` instances. This affects compatibility with Simba ODBC driver. This PR migrates this SQL option as a `SQLConfEntry` to fix this issue. Author: Cheng Lian <[email protected]> Closes #8925 from liancheng/spark-10845/hive-version-conf. (cherry picked from commit 6f94d56) Signed-off-by: Reynold Xin <[email protected]>
|
I backported this into branch-1.5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When refactoring SQL options from plain strings to the strongly typed
SQLConfEntry,spark.sql.hive.versionwasn't migrated, and doesn't show up in the result ofSET -v, asSET -vonly shows publicSQLConfEntryinstances. This affects compatibility with Simba ODBC driver.This PR migrates this SQL option as a
SQLConfEntryto fix this issue.