Skip to content

Conversation

@chenghao-intel
Copy link
Contributor

Floor & Ceiling function should returns Long type, rather than Double.

Verified with MySQL & Hive.

@chenghao-intel
Copy link
Contributor Author

test this please

@chenghao-intel
Copy link
Contributor Author

cc @liancheng

@SparkQA
Copy link

SparkQA commented Sep 29, 2015

Test build #43081 has finished for PR 8933 at commit f5b602a.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • abstract class UnaryMathExpression(val f: Double => Double, name: String)
    • case class Ceil(child: Expression) extends UnaryMathExpression(math.ceil, "CEIL")
    • case class Floor(child: Expression) extends UnaryMathExpression(math.floor, "FLOOR")

@SparkQA
Copy link

SparkQA commented Sep 29, 2015

Test build #1830 has finished for PR 8933 at commit f5b602a.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Sep 30, 2015

Test build #43112 has finished for PR 8933 at commit 8dabd91.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • abstract class UnaryMathExpression(val f: Double => Double, name: String)
    • case class Ceil(child: Expression) extends UnaryMathExpression(math.ceil, "CEIL")
    • case class Floor(child: Expression) extends UnaryMathExpression(math.floor, "FLOOR")

@chenghao-intel
Copy link
Contributor Author

cc @rxin

@davies
Copy link
Contributor

davies commented Oct 1, 2015

LGTM, merging this into master. Should we also backport it into 1.5?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants