Skip to content

Conversation

@sun-rui
Copy link
Contributor

@sun-rui sun-rui commented Sep 29, 2015

The YARN backend doesn't like when user code calls System.exit, since it cannot know the exit status and thus cannot set an appropriate final status for the application.

This PR remove the usage of system.exit to exit the RRunner. Instead, when the R process running an SparkR script returns an exit code other than 0, throws SparkUserAppException which will be caught by ApplicationMaster and ApplicationMaster knows it failed. For other failures, throws SparkException.

@shivaram
Copy link
Contributor

Thanks @sun-rui for the PR. I didn't follow the problem report very closely -- Could you explain the fix in the PR description for it to be available in the future ?

@SparkQA
Copy link

SparkQA commented Sep 29, 2015

Test build #43077 has finished for PR 8938 at commit b296066.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@shivaram
Copy link
Contributor

cc @andrewor14

@shivaram
Copy link
Contributor

Thanks @sun-rui -- LGTM. I'll just give this some time to see if @andrewor14 has any comments.

@felixcheung
Copy link
Member

looks good

@andrewor14
Copy link
Contributor

OK, merging into master, thanks.

@asfgit asfgit closed this in c7b29ae Sep 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants