[SPARK-10938] [SQL] remove typeId in columnar cache #8989
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @liancheng @rxin |
Contributor
There was a problem hiding this comment.
can we move this into execution.columnar?
Contributor
Author
There was a problem hiding this comment.
I'd like not to move it by this reason.
Contributor
Author
There was a problem hiding this comment.
Are you suggesting that we should move everything except public API into execution? That sounds good.
Contributor
There was a problem hiding this comment.
Yup. It would be great to minimize the number of top packages we have. You can do it in a followup pr too.
Contributor
|
LGTM |
|
Test build #43261 has finished for PR 8989 at commit
|
|
Test build #43273 has finished for PR 8989 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR remove the typeId in columnar cache, it's not needed anymore, it also remove DATE and TIMESTAMP (use INT/LONG instead).