-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-10382] Make example code in user guide testable #9109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
f4380f8
add code render
yinxusen 0f1d2f9
reduce code
yinxusen b0c1568
add new include example
yinxusen 02a9a0a
workable version
yinxusen 0236248
version 2
yinxusen d5f2569
render with Pygments
yinxusen 830d1b9
add POC example
yinxusen 0dbcfe9
revert changes in SparkALS
yinxusen 78c07ae
fix indentions
yinxusen 52b4368
fix style
yinxusen 8557977
remove changes in examples
yinxusen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,96 @@ | ||
| # | ||
| # Licensed to the Apache Software Foundation (ASF) under one or more | ||
| # contributor license agreements. See the NOTICE file distributed with | ||
| # this work for additional information regarding copyright ownership. | ||
| # The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| # (the "License"); you may not use this file except in compliance with | ||
| # the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| # | ||
|
|
||
| require 'liquid' | ||
| require 'pygments' | ||
|
|
||
| module Jekyll | ||
| class IncludeExampleTag < Liquid::Tag | ||
|
|
||
| def initialize(tag_name, markup, tokens) | ||
| @markup = markup | ||
| super | ||
| end | ||
|
|
||
| def render(context) | ||
| site = context.registers[:site] | ||
| config_dir = (site.config['code_dir'] || '../examples/src/main').sub(/^\//,'') | ||
| @code_dir = File.join(site.source, config_dir) | ||
|
|
||
| clean_markup = @markup.strip | ||
| @file = File.join(@code_dir, clean_markup) | ||
| @lang = clean_markup.split('.').last | ||
|
|
||
| code = File.open(@file).read.encode("UTF-8") | ||
| code = select_lines(code) | ||
|
|
||
| Pygments.highlight(code, :lexer => @lang) | ||
| end | ||
|
|
||
| # Trim the code block so as to have the same indention, regardless of their positions in the | ||
| # code file. | ||
| def trim_codeblock(lines) | ||
| # Select the minimum indention of the current code block. | ||
| min_start_spaces = lines | ||
| .select { |l| l.strip.size !=0 } | ||
| .map { |l| l[/\A */].size } | ||
| .min | ||
|
|
||
| lines.map { |l| l[min_start_spaces .. -1] } | ||
| end | ||
|
|
||
| # Select lines according to labels in code. Currently we use "$example on$" and "$example off$" | ||
| # as labels. Note that code blocks identified by the labels should not overlap. | ||
| def select_lines(code) | ||
| lines = code.each_line.to_a | ||
|
|
||
| # Select the array of start labels from code. | ||
| startIndices = lines | ||
| .each_with_index | ||
| .select { |l, i| l.include? "$example on$" } | ||
| .map { |l, i| i } | ||
|
|
||
| # Select the array of end labels from code. | ||
| endIndices = lines | ||
| .each_with_index | ||
| .select { |l, i| l.include? "$example off$" } | ||
| .map { |l, i| i } | ||
|
|
||
| raise "Start indices amount is not equal to end indices amount, please check the code." \ | ||
| unless startIndices.size == endIndices.size | ||
|
|
||
| raise "No code is selected by include_example, please check the code." \ | ||
| if startIndices.size == 0 | ||
|
|
||
| # Select and join code blocks together, with a space line between each of two continuous | ||
| # blocks. | ||
| lastIndex = -1 | ||
| result = "" | ||
| startIndices.zip(endIndices).each do |start, endline| | ||
| raise "Overlapping between two example code blocks are not allowed." if start <= lastIndex | ||
| raise "$example on$ should not be in the same line with $example off$." if start == endline | ||
| lastIndex = endline | ||
| range = Range.new(start + 1, endline - 1) | ||
| result += trim_codeblock(lines[range]).join | ||
| result += "\n" | ||
| end | ||
| result | ||
| end | ||
| end | ||
| end | ||
|
|
||
| Liquid::Template.register_tag('include_example', Jekyll::IncludeExampleTag) | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add Apache header? See
copy_api_dirs.rb.