Skip to content

Conversation

@yhuai
Copy link
Contributor

@yhuai yhuai commented Oct 19, 2015

This PR is a test fix for SPARK-11194 in branch 1.5. However, since it fundamentally changes the way that we do add jar in branch 1.5, we will not merge it into 1.5 branch.

@SparkQA
Copy link

SparkQA commented Oct 20, 2015

Test build #43942 has finished for PR 9171 at commit c06d9ac.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yhuai
Copy link
Contributor Author

yhuai commented Oct 20, 2015

test this please

@SparkQA
Copy link

SparkQA commented Oct 20, 2015

Test build #43959 has finished for PR 9171 at commit c06d9ac.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this pr also suffers the same problem exposed in #9170. There was no test failure because we only set the mutable classloader when we actually do add jar (In #9170 we set the mutable classloader to executionHive.state.getConf whenever we need to use withHiveState).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changed the classloader to a non-closable mutable url class loader.

@SparkQA
Copy link

SparkQA commented Oct 23, 2015

Test build #44233 has finished for PR 9171 at commit 7951df1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@davies
Copy link
Contributor

davies commented Oct 28, 2015

LGTM

@yhuai
Copy link
Contributor Author

yhuai commented Oct 28, 2015

Cool thanks for reviewing it. I will close it since it will not go in 1.5 branch.

@yhuai yhuai closed this Oct 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants